Replace in_array() by isset()

Author: andrey-legayev

app/code/Magento/Catalog/Model/ResourceModel/Eav/Attribute.php

@@ -38,6 +38,18 @@ class Attribute extends \Magento\Eav\Model\Entity\Attribute implements
 
     const KEY_IS_GLOBAL = 'is_global';
 
+    private const ALLOWED_INPUT_TYPES = [
+        'boolean'     => true,
+        'date'        => true,
+        'datetime'    => true,
+        'multiselect' => true,
+        'price'       => true,
+        'select'      => true,
+        'text'        => true,
+        'textarea'    => true,
+        'weight'      => true,
+    ];
+
     /**
      * @var LockValidatorInterface
      */
@@ -403,18 +415,7 @@ public function getSourceModel()
      */
     public function isAllowedForRuleCondition()
     {
-        $allowedInputTypes = [
-            'boolean',
-            'date',
-            'datetime',
-            'multiselect',
-            'price',
-            'select',
-            'text',
-            'textarea',
-            'weight',
-        ];
-        return $this->getIsVisible() && in_array($this->getFrontendInput(), $allowedInputTypes);
+        return $this->getIsVisible() && isset(self::ALLOWED_INPUT_TYPES[$this->getFrontendInput()]);
     }
 
     /**

lib/internal/Magento/Framework/DB/Select/SelectRenderer.php

@@ -12,6 +12,11 @@
  */
 class SelectRenderer implements RendererInterface
 {
+    private const MANDATORY_SELECT_PARTS = [
+        Select::COLUMNS => true,
+        Select::FROM    => true
+    ];
+
     /**
      * @var RendererInterface[]
      */
@@ -67,7 +72,8 @@ public function render(Select $select, $sql = '')
     {
         $sql = Select::SQL_SELECT;
         foreach ($this->renderers as $renderer) {
-            if (in_array($renderer['part'], [Select::COLUMNS, Select::FROM]) || $select->getPart($renderer['part'])) {
+            $part = $renderer['part'];
+            if (isset(self::MANDATORY_SELECT_PARTS[$part]) || $select->getPart($part)) {
                 $sql = $renderer['renderer']->render($select, $sql);
             }
         }

lib/internal/Magento/Framework/Module/Dir.php

@@ -22,6 +22,14 @@ class Dir
     const MODULE_SETUP_DIR = 'Setup';
     /**#@-*/
 
+    private const ALLOWED_DIR_TYPES = [
+        self::MODULE_ETC_DIR => true,
+        self::MODULE_I18N_DIR => true,
+        self::MODULE_VIEW_DIR => true,
+        self::MODULE_CONTROLLER_DIR => true,
+        self::MODULE_SETUP_DIR => true
+    ];
+
     /**#@-*/
     private $componentRegistrar;
 
@@ -52,13 +60,7 @@ public function getDir($moduleName, $type = '')
         }
 
         if ($type) {
-            if (!in_array($type, [
-                self::MODULE_ETC_DIR,
-                self::MODULE_I18N_DIR,
-                self::MODULE_VIEW_DIR,
-                self::MODULE_CONTROLLER_DIR,
-                self::MODULE_SETUP_DIR
-            ])) {
+            if (!isset(self::ALLOWED_DIR_TYPES[$type])) {
                 throw new \InvalidArgumentException("Directory type '{$type}' is not recognized.");
             }
             $path .= '/' . $type;