MC-19791: Poor performance on sales order update - string to integer

Author: Oleksandr Iegorov

lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php

@@ -785,6 +785,24 @@ protected function saveNewObject(\Magento\Framework\Model\AbstractModel $object)
         }
     }
 
+    /**
+     * Check in column value should be quoted
+     *
+     * Based on column description
+     *
+     * @param array $columnDescription
+     * @return bool
+     */
+    private function isNeedToQuoteValue(array $columnDescription): bool
+    {
+        $result = true;
+        if (!empty($columnDescription['DATA_TYPE'])
+            && in_array($columnDescription['DATA_TYPE'], ['smallint', 'int'])) {
+            $result = false;
+        }
+        return $result;
+    }
+
     /**
      * Update existing object
      *
@@ -798,7 +816,9 @@ protected function updateObject(\Magento\Framework\Model\AbstractModel $object)
         $connection = $this->getConnection();
         $tableDescription = $connection->describeTable($this->getMainTable());
         $preparedValue = $connection->prepareColumnValue($tableDescription[$this->getIdFieldName()], $object->getId());
-        $condition  = $this->getIdFieldName() . '=' . $preparedValue;
+        $condition  = (!$this->isNeedToQuoteValue($tableDescription[$this->getIdFieldName()]))
+            ? $this->getIdFieldName() . '=' . $preparedValue
+            : $connection->quoteInto($this->getIdFieldName() . '=?', $preparedValue);
 
         /**
          * Not auto increment primary key support

lib/internal/Magento/Framework/Model/Test/Unit/ResourceModel/Db/AbstractDbTest.php

@@ -496,7 +496,7 @@ public function testPrepareDataForUpdate()
             ->with(
                 'tableName',
                 $newData,
-                'idFieldName=0'
+                'idFieldName'
             );
         $select = $this->getMockBuilder(\Magento\Framework\DB\Select::class)
             ->disableOriginalConstructor()