MAGETWO-96242: High Database Load for Sales Rule Validation

Oleksandr Iegorov · Oleksandr Iegorov · commit c09917255cff · 2019-01-18T15:05:04.000-06:00
diff --git a/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Collection.php b/app/code/Magento/SalesRule/Model/ResourceModel/Rule/Collection.php
@@ -190,9 +190,9 @@ public function setValidationFilter(
      * Get rules ids related to coupon code
      *
      * @param string $couponCode
-     * @return array|null
+     * @return array
      */
-    private function getCouponRelatedRuleIds(string $couponCode): ?array
+    private function getCouponRelatedRuleIds(string $couponCode): array
     {
         $connection = $this->getConnection();
         $select = $connection->select()->from(

Original file line number	Diff line number	Diff line change
`@@ -190,9 +190,9 @@ public function setValidationFilter(`
`190`	`190`	`* Get rules ids related to coupon code`
`191`	`191`	`*`
`192`	`192`	`* @param string $couponCode`
`193`		`- * @return array\|null`
	`193`	`+ * @return array`
`194`	`194`	`*/`
`195`		`- private function getCouponRelatedRuleIds(string $couponCode): ?array`
	`195`	`+ private function getCouponRelatedRuleIds(string $couponCode): array`
`196`	`196`	`{`
`197`	`197`	`$connection = $this->getConnection();`
`198`	`198`	`$select = $connection->select()->from(`