Skip to content

Commit d42605a

Browse files
Devagouda PatilDevagouda Patil
Devagouda Patil
authored and
Devagouda Patil
committed
MAGETWO-93978: Footer Overlaps Storefront Page Content In Mobile View
- Added functional test to cover bug fix
1 parent fcd6f27 commit d42605a

File tree

3 files changed

+53
-0
lines changed

3 files changed

+53
-0
lines changed

‎app/code/Magento/Cms/Test/Mftf/Data/CmsPageData.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,10 @@
8080
<entity name="ImageFolder" type="uploadImage">
8181
<data key="name" unique="suffix">Test</data>
8282
</entity>
83+
<entity name="_longContentCmsPage" type="cms_page">
84+
<data key="title">Test CMS Page</data>
85+
<data key="content_heading">Test Content Heading</data>
86+
<data key="content">Sample long page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada. Sample page content. Yada yada yada.</data>
87+
<data key="identifier" unique="suffix">test-page-</data>
88+
</entity>
8389
</entities>

‎app/code/Magento/Cms/Test/Mftf/Section/StorefrontCMSPageSection.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,9 @@
1212
<element name="mediaDescription" type="text" selector=".column.main>p>img"/>
1313
<element name="imageSource" type="text" selector="//img[contains(@src,'{{var1}}')]" parameterized="true"/>
1414
<element name="mainTitle" type="text" selector="#maincontent .page-title"/>
15+
<element name="mainContent" type="text" selector="#maincontent"/>
16+
</section>
17+
<section name="StorefrontCMSPageFooterSection">
18+
<element name="footerSection" type="text" selector="footer.page-footer"/>
1519
</section>
1620
</sections>

‎app/code/Magento/Cms/Test/Mftf/Test/StoreFrontMobileViewValidation.xml

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
11+
<test name="StoreFrontMobileViewValidation">
12+
<annotations>
13+
<features value="Cms"/>
14+
<title value="Mobile view page footer should stick to the bottom of page on Store front"/>
15+
<description value="Mobile view page footer should stick to the bottom of page on Store front"/>
16+
<severity value="MAJOR"/>
17+
<testCaseId value="MAGETWO-94333"/>
18+
<group value="Cms12"/>
19+
</annotations>
20+
<before>
21+
<createData entity="_longContentCmsPage" stepKey="createPreReqCMSPage"/>
22+
</before>
23+
<after>
24+
<deleteData createDataKey="createPreReqCMSPage" stepKey="deletePreReqCMSPage"/>
25+
</after>
26+
<resizeWindow width="375" height="812" stepKey="resizeWindowToDesktop"/>
27+
<amOnPage url="$$createPreReqCMSPage.identifier$$" stepKey="amOnPageTestPage"/>
28+
<waitForPageLoad stepKey="waitForPageLoad6" />
29+
<!--check header/footer location on Storefront-->
30+
<executeJS function="return document.querySelector('{{StorefrontCMSPageFooterSection.footerSection}}').getBoundingClientRect().top" stepKey="topOfFooter"/>
31+
<assertGreaterThan stepKey="assertDefaultLoad">
32+
<actualResult type="variable">topOfFooter</actualResult>
33+
<expectedResult type="string">812</expectedResult>
34+
</assertGreaterThan>
35+
<scrollTo selector="{{StorefrontCMSPageFooterSection.footerSection}}" stepKey="scrollToFooterSection"/>
36+
<executeJS function="return document.querySelector('{{StorefrontCMSPageFooterSection.footerSection}}').getBoundingClientRect().top" stepKey="bottomOfFooter"/>
37+
<executeJS function="return document.querySelector('{{StorefrontCMSPageSection.mainContent}}').getBoundingClientRect().bottom" stepKey="mainContent"/>
38+
<assertGreaterThan stepKey="assertAfterScroll">
39+
<actualResult type="variable">bottomOfFooter</actualResult>
40+
<expectedResult type="variable">mainContent</expectedResult>
41+
</assertGreaterThan>
42+
</test>
43+
</tests>

0 commit comments

Comments
 (0)