AC-10821: Static Test fixes

Author: nishant04412

app/code/Magento/Backend/Test/Unit/Block/Page/System/Config/Robots/ResetTest.php

@@ -55,7 +55,7 @@ protected function setUp(): void
     }
 
     /**
-     * @covers Reset::getRobotsDefaultCustomInstructions
+     * @covers \Magento\Backend\Block\Page\System\Config\Robots\Reset::getRobotsDefaultCustomInstructions
      */
     public function testGetRobotsDefaultCustomInstructions()
     {

app/code/Magento/CatalogInventory/Test/Unit/Model/Quote/Item/QuantityValidator/Initializer/OptionTest.php

@@ -125,7 +125,14 @@ protected function setUp(): void
         );
         $this->resultMock = $this->getMockBuilder(DataObject::class)
             ->addMethods(
-                ['getItemIsQtyDecimal', 'getHasQtyOptionUpdate', 'getOrigQty', 'getMessage', 'getItemBackorders', 'getItemQty']
+                [
+                    'getItemIsQtyDecimal',
+                    'getHasQtyOptionUpdate',
+                    'getOrigQty',
+                    'getMessage',
+                    'getItemBackorders',
+                    'getItemQty'
+                ]
             )
             ->disableOriginalConstructor()
             ->getMock();

app/code/Magento/CatalogInventory/Test/Unit/Model/Stock/StockItemRepositoryTest.php

@@ -123,8 +123,8 @@ protected function setUp(): void
             ->addMethods(
                 [
                     'setStockStatusChangedAutomaticallyFlag',
-                    'hasStockStatusChangedAutomaticallyFlag',
-
+                    'getStockStatusChangedAutomaticallyFlag',
+                    'hasStockStatusChangedAutomaticallyFlag'
                 ]
             )
             ->onlyMethods(
@@ -331,7 +331,7 @@ public function testSave(
             'setStockId' => ['expects' => $this->once(), 'with' => [1], 'willReturnSelf' => true,],
             'setLowStockDate' => [
                 'expects' => $this->exactly(2),
-                'withConsecutive' => [[null], [$date],],
+                'willReturnCallback' => [[null], [$date],],
                 'willReturnSelf' => true,
             ],
             'hasStockStatusChangedAutomaticallyFlag' => ['expects' => $this->once(), 'willReturn' => false,],
@@ -427,7 +427,7 @@ public function testGetList()
     /**
      * @return array
      */
-    public function saveDataProvider(): array
+    public static function saveDataProvider(): array
     {
         return [
             'should set isInStock=true if: verifyStock=true, isInStock=false, stockStatusChangedAuto=true' => [
@@ -438,55 +438,55 @@ public function saveDataProvider(): array
             'should not set isInStock=true if: verifyStock=true, isInStock=false, stockStatusChangedAuto=false' => [
                 'stockStateProviderMockConfig' => [],
                 'stockItemMockConfig' => [
-                    'setIsInStock' => ['expects' => $this->never(),],
-                    'setStockStatusChangedAuto' => ['expects' => $this->never()],
-                    'getStockStatusChangedAuto' => ['expects' => $this->once(), 'willReturn' => false,],
+                    'setIsInStock' => ['expects' => self::never(),],
+                    'setStockStatusChangedAuto' => ['expects' => self::never()],
+                    'getStockStatusChangedAuto' => ['expects' => self::once(), 'willReturn' => false,],
                 ],
                 'existingStockItemMockConfig' => [],
             ],
             'should set isInStock=false and stockStatusChangedAuto=true if: verifyStock=false and isInStock=true' => [
                 'stockStateProviderMockConfig' => [
-                    'verifyStock' => ['expects' => $this->once(), 'willReturn' => false,],
+                    'verifyStock' => ['expects' => self::once(), 'willReturn' => false,],
                 ],
                 'stockItemMockConfig' => [
-                    'getIsInStock' => ['expects' => $this->any(), 'willReturn' => true,],
-                    'getStockStatusChangedAuto' => ['expects' => $this->never(),],
-                    'setIsInStock' => ['expects' => $this->once(), 'with' => [false],],
-                    'setStockStatusChangedAuto' => ['expects' => $this->once(), 'with' => [1],],
+                    'getIsInStock' => ['expects' => self::any(), 'willReturn' => true,],
+                    'getStockStatusChangedAuto' => ['expects' => self::never(),],
+                    'setIsInStock' => ['expects' => self::once(), 'with' => [false],],
+                    'setStockStatusChangedAuto' => ['expects' => self::once(), 'with' => [1],],
                 ],
                 'existingStockItemMockConfig' => [],
             ],
             'should set stockStatusChangedAuto=true if: verifyStock=false and isInStock=false' => [
                 'stockStateProviderMockConfig' => [
-                    'verifyStock' => ['expects' => $this->once(), 'willReturn' => false,],
+                    'verifyStock' => ['expects' => self::once(), 'willReturn' => false,],
                 ],
                 'stockItemMockConfig' => [
-                    'getIsInStock' => ['expects' => $this->any(), 'willReturn' => false,],
-                    'getStockStatusChangedAuto' => ['expects' => $this->never(),],
-                    'setIsInStock' => ['expects' => $this->never(),],
-                    'setStockStatusChangedAuto' => ['expects' => $this->never(),],
+                    'getIsInStock' => ['expects' => self::any(), 'willReturn' => false,],
+                    'getStockStatusChangedAuto' => ['expects' => self::never(),],
+                    'setIsInStock' => ['expects' => self::never(),],
+                    'setStockStatusChangedAuto' => ['expects' => self::never(),],
                 ],
                 'existingStockItemMockConfig' => [],
             ],
             'should set stockStatusChangedAuto=true if: stockStatusChangedAutomaticallyFlag=true' => [
                 'stockStateProviderMockConfig' => [],
                 'stockItemMockConfig' => [
-                    'getStockStatusChangedAuto' => ['expects' => $this->once(), 'willReturn' => false,],
-                    'setIsInStock' => ['expects' => $this->never(),],
-                    'setStockStatusChangedAuto' => ['expects' => $this->once(), 'with' => [1],],
-                    'hasStockStatusChangedAutomaticallyFlag' => ['expects' => $this->once(), 'willReturn' => true,],
-                    'getStockStatusChangedAutomaticallyFlag' => ['expects' => $this->once(), 'willReturn' => true,],
+                    'getStockStatusChangedAuto' => ['expects' =>self::once(), 'willReturn' => false,],
+                    'setIsInStock' => ['expects' => self::never(),],
+                    'setStockStatusChangedAuto' => ['expects' => self::once(), 'with' => [1],],
+                    'hasStockStatusChangedAutomaticallyFlag' => ['expects' => self::once(), 'willReturn' => true,],
+                    'getStockStatusChangedAutomaticallyFlag' => ['expects' => self::once(), 'willReturn' => true,],
                 ],
                 'existingStockItemMockConfig' => [
                 ],
             ],
             'should set stockStatusChangedAuto=false if: getManageStock=false' => [
                 'stockStateProviderMockConfig' => [],
                 'stockItemMockConfig' => [
-                    'getManageStock' => ['expects' => $this->once(), 'willReturn' => false],
-                    'getStockStatusChangedAuto' => ['expects' => $this->never(), 'willReturn' => false,],
-                    'setIsInStock' => ['expects' => $this->never(),],
-                    'setStockStatusChangedAuto' => ['expects' => $this->once(), 'with' => [0],],
+                    'getManageStock' => ['expects' => self::once(), 'willReturn' => false],
+                    'getStockStatusChangedAuto' => ['expects' => self::never(), 'willReturn' => false,],
+                    'setIsInStock' => ['expects' => self::never(),],
+                    'setStockStatusChangedAuto' => ['expects' => self::once(), 'with' => [0],],
                 ],
                 'existingStockItemMockConfig' => [
                 ],
@@ -506,10 +506,8 @@ private function configMock(MockObject $mockObject, array $configs): void
             if (isset($config['with'])) {
                 $mockMethod->with(...$config['with']);
             }
-            if (isset($config['withConsecutive'])) {
-                $mockMethod->willReturnCallback(fn($param) => match ([$param]) {
-                    [...$config['withConsecutive']] => $mockMethod
-                });
+            if (isset($config['willReturnCallback'])) {
+                $mockMethod->willReturnCallback(...$config['willReturnCallback']);
             }
             if (isset($config['willReturnSelf'])) {
                 $mockMethod->willReturnSelf();

app/code/Magento/CatalogRule/Test/Unit/Observer/ProcessAdminFinalPriceObserverTest.php

@@ -35,29 +35,21 @@ class ProcessAdminFinalPriceObserverTest extends TestCase
     private $observer;
 
     /**
-     * Store Manager mock
-     *
      * @var StoreManagerInterface
      */
     private $storeManagerMock;
 
     /**
-     * Locale Date mock
-     *
      * @var TimezoneInterface
      */
     private $localeDateMock;
 
     /**
-     * Resource Rule Factory mock
-     *
      * @var RuleFactory
      */
     private $resourceRuleFactoryMock;
 
     /**
-     * Rule Prices Storage mock
-     *
      * @var RulePricesStorage
      */
     private $rulePricesStorageMock;

app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Storage/DynamicStorageTest.php

@@ -198,6 +198,7 @@ public function testFindProductRewriteByRequestPath(
 
     /**
      * @return array
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function findProductRewriteByRequestPathDataProvider(): array
     {

app/code/Magento/Checkout/Test/Unit/Block/Shipping/PriceTest.php

@@ -18,8 +18,6 @@
 
 class PriceTest extends TestCase
 {
-    const SUBTOTAL = 10;
-
     /**
      * @var Price
      */