Improve performance when resized image URL is accessed but does not yet exist.#40388
Open
rogerdz wants to merge 1 commit intomagento:2.4-developfrom
Open
Improve performance when resized image URL is accessed but does not yet exist.#40388rogerdz wants to merge 1 commit intomagento:2.4-developfrom
rogerdz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @rogerdz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Contributor
|
@magento create issue |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Default Magento generate resize image for all image id (example:product_base_image , product_swatch_image_large, product_page_more_views, ...) when resized image URL is accessed but does not yet exist.
This increases response time and disk I/O.
Test with PR when accessing one missing resized image URL, response time decreased from 1s to 150ms
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: