Skip to content

Conversation

glo80684
Copy link
Collaborator

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo80684 glo80684 closed this Sep 29, 2025
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 29, 2025

Fails
🚫 Lighthouse assertions failed 😔. All assertions must pass before this PR can be merged
https://pr-4555.pwa-venia.com/

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 520
  • Actual: 592
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/

Total Blocking Time (minScore)

  • Expected: 0.35
  • Actual: 0.32
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-total-blocking-time/
https://pr-4555.pwa-venia.com/venia-tops.html?page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed
https://pr-4555.pwa-venia.com/valeria-two-layer-tank.html

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed
https://pr-4555.pwa-venia.com/search.html?query=tops&page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 520
  • Actual: 586
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
🚫

node failed.

Log

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-d45591dd.json

Generated by 🚫 dangerJS against 8d78aac

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

The following file(s) did not pass ESLint. Execute yarn run lint locally for more details

venia-integration-tests/package.json
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: eslintCheck


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 8d78aac

@glo80684 glo80684 reopened this Sep 29, 2025
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 29, 2025

Fails
🚫 Lighthouse assertions failed 😔. All assertions must pass before this PR can be merged
https://pr-4555.pwa-venia.com/

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 144
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
https://pr-4555.pwa-venia.com/venia-tops.html?page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 144
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
https://pr-4555.pwa-venia.com/valeria-two-layer-tank.html

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 143.9999999999999
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
https://pr-4555.pwa-venia.com/search.html?query=tops&page=1

categories.pwa (auditRan)

  • Expected: 1
  • Actual: 0
  • Result: Failed

Max Potential First Input Delay (maxNumericValue)

  • Expected: 127
  • Actual: 143
  • Result: Failed
  • Docs link: https://developer.chrome.com/docs/lighthouse/performance/lighthouse-max-potential-fid/
🚫

node failed.

Log

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-6d58696c.json

Generated by 🚫 dangerJS against 8d78aac

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 29, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • Verify venia anchor links:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: `[data-cy="GuestForm-root"]`, but never found it.
  • user should be able to add and update gift options:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlGetProductListingQuery`. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to navigate on offline mode:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetStoreConfigDataQuery. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to place an order as a registered customer:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CheckoutPage-signInButton"], but never found it.

    Registered user should be able to sign in from toast suggestion in guest checkout page:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="GuestForm-email"], but never found it.
  • user can fill and submit payment form and place order with inline badge position:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CartPage-root"] [data-cy="ProductListing-root"] [data-cy="Product-name"], but never found it.

    user can fill and submit payment form and place order with default badge position:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CartPage-root"] [data-cy="ProductListing-root"] [data-cy="Product-name"], but never found it.
  • verify search suggest products:
    • AssertionError: Timed out retrying after 30000ms: expected { Object (type, payload) } to deeply equal { Object (payload, type) }
  • user should be able to remove an item from the cart:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetProductListingQuery. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to filter results in Category and Search pages:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetProductFiltersByCategoryQuery. No request ever occurred.

      https://on.cypress.io/wait


    user should be able to use radio-boolean filter results in Category and Search pages:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetProductFiltersByCategoryQuery. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to add and remove products from wishlist:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to create a new account and edit their information:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to add and remove promotions from cart:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetAppliedCouponsQuery. No request ever occurred.

      https://on.cypress.io/wait

  • should be able to edit a configurable product and place an order:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CreditCard-root"] [id*="braintree-hosted-field-cardholderName"], but never found it.
  • displays assigned products:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"], but never found it.
    ,shows products specific to the categories in the different store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CategoryContent-root"] [data-cy="GalleryItem-name"], [data-cy="SearchPage-root"] [data-cy="GalleryItem-name"], but never found it.
    ,lets users add products to cart regardless of store view:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="CategoryContent-root"] [data-cy="GalleryItem-root"], but never found it.
  • user should be able to place an order as a guest:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlGetShippingMethodsQuery. No request ever occurred.

      https://on.cypress.io/wait

  • user should be able to place an order as a guest with an specified Region and a credit card:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4555.pwa-venia.com/valeria-two-layer-tank.html

      The response we received from your web server was:

      502: Bad Gateway

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

  • user should be able to add and remove products from wishlist:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait

  • should display Default Store View and USD currency by default:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-switchers"] [data-cy="StoreSwitcher-root"] [data-cy="StoreSwitcher-trigger"], but never found it.

    should display EUR currency by default if French Store View is selected:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-switchers"] [data-cy="StoreSwitcher-root"] [data-cy="StoreSwitcher-trigger"], but never found it.

    should be able to place an order in French store:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-switchers"] [data-cy="StoreSwitcher-root"] [data-cy="StoreSwitcher-trigger"], but never found it.

    should display English text and USD currency accross app if Default Store View is selected:
    • CypressError: Timed out retrying after 60000ms: cy.wait() timed out waiting 60000ms for the 1st request to the route: gqlSignInAfterCreateMutation. No request ever occurred.

      https://on.cypress.io/wait


    should display French text and EUR currency accross app if French Store View is selected:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-switchers"] [data-cy="StoreSwitcher-root"] [data-cy="StoreSwitcher-trigger"], but never found it.

    should show USD currency across app if it is selected inside French Store View:
    • AssertionError: Timed out retrying after 30000ms: Expected to find element: [data-cy="Header-switchers"] [data-cy="StoreSwitcher-root"] [data-cy="StoreSwitcher-trigger"], but never found it.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 8d78aac

@glo80684 glo80684 closed this Sep 29, 2025
@glo80684 glo80684 reopened this Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants