dateFormat in slider edit based on admin user locale#80
Open
LusienGG wants to merge 2 commits intomageplaza:2.4from
Open
dateFormat in slider edit based on admin user locale#80LusienGG wants to merge 2 commits intomageplaza:2.4from
LusienGG wants to merge 2 commits intomageplaza:2.4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I`ve been facing an issue with this extension for a long time ( 2 years ) where users with different locale are editing the start/end date of the banners.
Examples to test:
Make your admin user with the country option Bulgaria for example.
Create a slider with start date 12 Feb 2021 using js datepicker.
As expected from the hardcoded format and the locale:
I am just contributing my fix to the issue for the community.