Add full page cache support to post listings#293
Open
aapokiiso wants to merge 1 commit intomageplaza:2.4from
Open
Add full page cache support to post listings#293aapokiiso wants to merge 1 commit intomageplaza:2.4from
aapokiiso wants to merge 1 commit intomageplaza:2.4from
Conversation
|
This PR fixes #287 Code checks failing sucks when its not really the change's issue. It is implenting a mandatory interface and then using the proper public class constant from the entity. In my opinion the rules should be reworked to better meet the code base's requirements. |
gocom
approved these changes
Oct 25, 2020
Contributor
|
hi @aapokiiso, We highly appreciate and idea like you to make our product better. |
Author
|
@phutx Hi, thanks for the comment! It would be great if eventually the module would not use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Magento gathers all identities from blocks and adds them to the X-Magento-Tags header for the page.
By adding the post cache tag to the post list identities, pages cached to the full page cache
containing post lists are cleared from the full page cache when any post is saved in Magento.
Additionally fixed a bug where the post model didn't implement the identity interface.
Without implementing the interface, Magento is not aware that the post model has identities.
Manual testing scenarios
Contribution checklist