Skip to content

PHP 8.4 compatibility#26

Open
peterjaap wants to merge 2 commits intomageplaza:2.4from
peterjaap:php84-compat
Open

PHP 8.4 compatibility#26
peterjaap wants to merge 2 commits intomageplaza:2.4from
peterjaap:php84-compat

Conversation

@peterjaap
Copy link

Description

Fixed Issues (if relevant)

  1. https://github.com/mageplaza/magento-2-reports/<issue_number>: Issue title
  2. ...

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@mariuszsienkiewicz
Copy link

mariuszsienkiewicz commented May 29, 2025

Hi, I ran into the same issue with PHP 8.4 — thanks for looking into it! That said, I believe some of the changes you made aren't quite correct. Specifically, the updates in:

  • Helper/Data.php
  • Helper/Email.php
  • Console/Delete.php

aren’t valid, because in PHP 8.4 (or any other version) you can’t use ? for nullable types unless a type is explicitly declared (e.g., ?int $storeId). It would be better to either add the appropriate type hint or remove the ? if no type is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants