Skip to content

fix(swatch-renderer-ext): Only display/hide price tooltips of the clicked product tile cell, not of all cells#50

Open
jtomaszewski wants to merge 1 commit intomagesuite:nextfrom
jtomaszewski:fix-product-list-price-label
Open

fix(swatch-renderer-ext): Only display/hide price tooltips of the clicked product tile cell, not of all cells#50
jtomaszewski wants to merge 1 commit intomagesuite:nextfrom
jtomaszewski:fix-product-list-price-label

Conversation

@jtomaszewski
Copy link
Contributor

When user is on a product listing page (e.g. category), and there are products with swatches, then the product has "From xxx" price. If user selects swatch, the price should change to "xxx" (the "From" word should disappear), but only for that one product.

However currently that "From" is hidden on all product tiles.

This commit fixes it.

For more info, see videos:

Before the change:

updatetilepricefix-before.mov

After the change:

updatetilepricefix-after.mov

@msiewierska
Copy link
Contributor

msiewierska commented Feb 23, 2021

@jtomaszewski Do you use the newest version of theme-creativeshop? It seems that the issue was fixed before internally. Please check if this commit fixed the issue: 711c8a5#diff-d8a8e4fae40dc6faf5826ec6c64af7c7c735b0223393d259fd1b5f358509872e

@jtomaszewski
Copy link
Contributor Author

We are... and we still need that workaround. Maybe it's because we also use magesuite/server-side-swatches ? Or maybe it's because of some other swatch-related plugin that we're also using... hard to tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments