Fix false login failures caused by stale OAuth session state#26
Merged
CarensirA-MF merged 1 commit intomasterfrom Apr 8, 2026
Merged
Fix false login failures caused by stale OAuth session state#26CarensirA-MF merged 1 commit intomasterfrom
CarensirA-MF merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MismatchingStateErrorseparately from generic OAuth errors in both Google and Keycloakcallbacks - Auto-retry the OAuth flow on stale session instead of showing "Authentication failed" to the user
INFOwith reason"stale_session"instead ofWARNINGwith"oauth_error"BEHIND_PROXY=trueset in Herokuconfig to fix 10.1.x.x IPs in audit logs)
Context
Audit logs were showing many login failures with
{"reason": "oauth_error", "email": null, "provider": "keycloak"}, each paired with a successful login from the same IP moments later. These are caused byusers returning to the app after their Flask session expires but while their Keycloak SSO session is
still active — the OAuth state token no longer matches, causing a benign
MismatchingStateError.