Draft
Conversation
Collaborator
|
@nasbench If we intend to introduce API Endpoints I think we should keep it more REST like. These would be my suggestions for changes:
Here some examples of how I imagine it:
Let me know what you think |
Member
Author
|
You went for the more official route :) My idea was just to do a quick API endpoints to get the data. But no worries, I'll make the changes to make REST like a little bit. Thanks for the suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of API endpoints to make it easy to integrate sigconverter into projects.
/getbackendsendpoint to list available backends/getformatsendpoint to list available formats per backend/getpipelineallowedbackendendpoint to list the allowed backends for every pipelineFYI: These will be used by the sigma vscode extensions