fix: AnimatedGridPattern hydration + effect loop + invalid DOM prop #858
+27
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #854 #848
Description
This PR focuses on fixing React warnings and hydration issues in the
AnimatedGridPatterncomponent.It also addresses a render loop / maximum update depth issue caused by unstable effect dependencies.
Changes
repeatDelayfrom leaking into the root<svg>via...props, removing the React warning.ResizeObservercleanup withdisconnect().Motivation
repeatDelayon DOM elements).Math.random()).Maximum update depth exceededand make resize handling more robust.Breaking Changes