This repository was archived by the owner on Jan 22, 2022. It is now read-only.
Fixed the fetch url password exclude bug#5
Open
anagri wants to merge 2 commits intomagnayn:masterfrom
Open
Conversation
…ord to toPrivateString which includes password
nukulb
pushed a commit
to nukulb/hudson-git-plugin
that referenced
this pull request
Jan 1, 2014
…L. Replace usages of toString() in plugin with toPrivateString() so the password is not elided. Original Source: magnayn/Hudson-GIT-plugin#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a repository over http with username and password embedded in the url. The plugin uses toString method of URIs which ignores the password field of the url. Because of this the commandline waits for a manual password entry in such cases. So I have switched the fetch url from one without password to one with password.