Fix susceptibility parent tree traversal #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling; add comprehensive tests for various input scenarios and edge cases
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the get_susceptibilities function in the demagnetization module by extracting complex conversion logic into separate helper functions. The changes aim to improve code maintainability and testability while adding comprehensive test coverage for various susceptibility input formats and edge cases.
- Refactored
get_susceptibilitiesto use helper functions_convert_to_arrayand_get_susceptibility_from_hierarchy - Added extensive parametrized tests covering basic functionality, hierarchical inheritance, error cases, and edge cases
- Added VS Code settings file for pytest configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/magpylib_material_response/demag.py | Refactored get_susceptibilities function to extract conversion logic into _convert_to_array and _get_susceptibility_from_hierarchy helper functions |
| tests/test_basic.py | Replaced old susceptibility test with comprehensive parametrized tests for integration, basic functionality, hierarchy, errors, and edge cases |
| .vscode/settings.json | Added VS Code pytest configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…ing configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Regression: Susceptibility parent tree traversal is broken #25
Adds extended tests