Skip to content

fix: Only check for ambiguity when susceptibility comes from user input, not from hierarchy #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: Only check for ambiguity when susceptibility comes from user input, not from hierarchy #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/magpylib_material_response/demag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ def get_susceptibilities(sources, susceptibility=None):
src_susceptibility = _get_susceptibility_from_hierarchy(src.parent)
susceptibilities.append(src_susceptibility)

susis = _convert_to_array(susceptibilities, n)
susis = _convert_to_array(susceptibilities, n, from_hierarchy=True)
else:
# Use function input susceptibility
susis = _convert_to_array(susceptibility, n)
susis = _convert_to_array(susceptibility, n, from_hierarchy=False)

return np.reshape(susis, 3 * n, order="F")


def _convert_to_array(susceptibility, n):
def _convert_to_array(susceptibility, n, from_hierarchy=False):
"""Convert susceptibility input(s) to (n, 3) array format"""
# Handle single values (scalar or 3-vector) applied to all sources
if np.isscalar(susceptibility):
Expand All @@ -70,7 +70,8 @@ def _convert_to_array(susceptibility, n):
):
# This is a 3-vector, not a list of 3 items
susis = np.tile(susceptibility, (n, 1))
if n == 3:
# Only check for ambiguity when susceptibility comes from user input, not from hierarchy
if n == 3 and not from_hierarchy:
msg = (
"Apply_demag input susceptibility is ambiguous - either scalar list or vector single entry. "
"Please choose different means of input or change the number of cells in the Collection."
Expand Down