Initial ci tooling/linting/typechecking #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update pyproject.toml * Tried Moving the SX1280 to Root * Trying Something Else * Taking Perplexity Rec * Moved Files * Appease the Linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some initial linting with ruff and some type hinting config. There are lots of red squigglies from pyright's type checking but with the addition of type stubs click-through works everywhere. A precommit config was added, UV is used to manage python environment, and a Makefile was added with basic targets to setup your environment. Just clone and run
make.The changes culminate with an initial CI action workflow that runs ruff.
We can also remove pyright and try to integrate it in a separate PR so we don't have so many red squeeegles. I'm also noticing that the pytoml references PROVES. Happy to change that if you know how you want things named.
Thoughts?