Skip to content
This repository was archived by the owner on Jan 7, 2020. It is now read-only.

Comments

fix(NAPI): Ref-napi ffi-napi added.#370

Open
joshuef wants to merge 1 commit intomaidsafe-archive:masterfrom
joshuef:NAPI
Open

fix(NAPI): Ref-napi ffi-napi added.#370
joshuef wants to merge 1 commit intomaidsafe-archive:masterfrom
joshuef:NAPI

Conversation

@joshuef
Copy link
Contributor

@joshuef joshuef commented Apr 25, 2019

Use NAPI where we can

Makes use of more modern node APIs
@joshuef joshuef requested a review from bochaco as a code owner April 25, 2019 08:26
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 96.417% when pulling 6cd9e4a on joshuef:NAPI into 72d68f5 on maidsafe:master.

Copy link
Contributor

@bochaco bochaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuef , I was testing this with the latest commit of browser from master, and setting in package.json

"@maidsafe/safe-node-app": "git+https://github.com/joshuef/safe_app_nodejs#NAPI"

But I'm seeing some instability which I can reproduce with this dependency only, e.g. I'm able to log in and then after I logged in if I switch the experimental APIs it doesn't finish reloading the authenticator page, or even if I had let's say Patter in another tab it doesn't reload it, or I cannot open a new tab and load a new website. This is not happening with latest commit from master and v0.11.0 of safe-node-app.

Then I went ahead and try to switch experimental APIs right after launching the browser before logging in, and I get this error: {"error_code":-2000,"description":"Core error: Unexpected: Could not connect to the SAFE Network"}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants