Skip to content

Ensure string is in scope for c_str() call #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure string is in scope for c_str() call #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/GPUCommandEncoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,7 @@ Napi::Value GPUCommandEncoder::copyImageBitmapToTexture(const Napi::CallbackInfo
Napi::Value GPUCommandEncoder::pushDebugGroup(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuCommandEncoderPushDebugGroup(this->instance, groupLabel);
wgpuCommandEncoderPushDebugGroup(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand All @@ -189,8 +188,7 @@ Napi::Value GPUCommandEncoder::popDebugGroup(const Napi::CallbackInfo &info) {
Napi::Value GPUCommandEncoder::insertDebugMarker(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuCommandEncoderInsertDebugMarker(this->instance, groupLabel);
wgpuCommandEncoderInsertDebugMarker(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand Down
6 changes: 2 additions & 4 deletions src/GPUComputePassEncoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ Napi::Value GPUComputePassEncoder::setBindGroup(const Napi::CallbackInfo &info)
Napi::Value GPUComputePassEncoder::pushDebugGroup(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuComputePassEncoderPushDebugGroup(this->instance, groupLabel);
wgpuComputePassEncoderPushDebugGroup(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand All @@ -111,8 +110,7 @@ Napi::Value GPUComputePassEncoder::popDebugGroup(const Napi::CallbackInfo &info)
Napi::Value GPUComputePassEncoder::insertDebugMarker(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuComputePassEncoderInsertDebugMarker(this->instance, groupLabel);
wgpuComputePassEncoderInsertDebugMarker(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand Down
6 changes: 2 additions & 4 deletions src/GPURenderBundleEncoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,7 @@ Napi::Value GPURenderBundleEncoder::setBindGroup(const Napi::CallbackInfo &info)
Napi::Value GPURenderBundleEncoder::pushDebugGroup(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuRenderBundleEncoderPushDebugGroup(this->instance, groupLabel);
wgpuRenderBundleEncoderPushDebugGroup(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand All @@ -179,8 +178,7 @@ Napi::Value GPURenderBundleEncoder::popDebugGroup(const Napi::CallbackInfo &info
Napi::Value GPURenderBundleEncoder::insertDebugMarker(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuRenderBundleEncoderInsertDebugMarker(this->instance, groupLabel);
wgpuRenderBundleEncoderInsertDebugMarker(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand Down
6 changes: 2 additions & 4 deletions src/GPURenderPassEncoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,7 @@ Napi::Value GPURenderPassEncoder::setBindGroup(const Napi::CallbackInfo &info) {
Napi::Value GPURenderPassEncoder::pushDebugGroup(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuRenderPassEncoderPushDebugGroup(this->instance, groupLabel);
wgpuRenderPassEncoderPushDebugGroup(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand All @@ -231,8 +230,7 @@ Napi::Value GPURenderPassEncoder::popDebugGroup(const Napi::CallbackInfo &info)
Napi::Value GPURenderPassEncoder::insertDebugMarker(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();

const char* groupLabel = info[0].As<Napi::String>().Utf8Value().c_str();
wgpuRenderPassEncoderInsertDebugMarker(this->instance, groupLabel);
wgpuRenderPassEncoderInsertDebugMarker(this->instance, info[0].As<Napi::String>().Utf8Value().c_str());

return env.Undefined();
}
Expand Down