Skip to content

Add a confirmation prompt before logging out the user. #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikrampm1 merged 2 commits into from
May 8, 2025
Merged

Add a confirmation prompt before logging out the user. #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70e9800
Add a confirmation prompt before logging out the user.
iamdharmesh Apr 10, 2025
cb7439f
E2E: Update E2E tests
iamdharmesh Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/cypress/e2e/logout.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ describe('Logout tests', () => {
it('Admin can logout', () => {
cy.visit('/wp-admin/admin.php?page=mailchimp_sf_options');
cy.get('#mailchimp_sf_oauth_connect').should('not.exist');

cy.on('window:confirm', (text) => {
expect(text).to.contains('Are you sure you want to log out?');
return true;
});

cy.get('input[value="Logout"]').click();

// connect to "Mailchimp" Account button should be visible.
Expand Down
2 changes: 1 addition & 1 deletion views/setup_page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<td><h3><?php esc_html_e( 'Logged in as', 'mailchimp' ); ?>: <?php echo esc_html( $user['username'] ); ?></h3>
</td>
<td>
<form method="post" action="">
<form method="post" action="" onsubmit="return confirm('<?php echo esc_js( __( 'Are you sure you want to log out?', 'mailchimp' ) ); ?>');">
<input type="hidden" name="mcsf_action" value="logout"/>
<input type="submit" name="Submit" value="<?php esc_attr_e( 'Logout', 'mailchimp' ); ?>" class="button button-secondary mailchimp-sf-button small" />
<?php wp_nonce_field( 'mc_logout', '_mcsf_nonce_action' ); ?>
Expand Down