Open
Conversation
omitzero was added to the go stdlib encoder/json in go 1.24
and does accept omitempty in the go stdlib encoder/json.
nsd20463
changed the title
nsd20463
changed the title
neal
reviewed
Dec 10, 2025
tests/data.go
Outdated
|
|
||
| // NOTE: omitzero DOES have effect on non-pointer struct fields. | ||
| SubZ, SubNZ SubStruct `json:",omitzero"` | ||
| SubPZ, SubPNZ *SubStruct `json:",omitzero"` |
Contributor
There was a problem hiding this comment.
may be worth also testing pointer values set with zero-value struct/string
Contributor
Author
There was a problem hiding this comment.
sure, why not. done.
(both should marshal to something in order to match stdlib json, and they do)
Without a special case the generated code can look like
if v != nil && v != nil {
or
if v != "" && v != "" {
and that gets flagged by go vet (go 1.25.5)
Contributor
Author
|
While adding more test cases I realized that combining omitempty and omitzero together generated code which didn't pass |
|
Any way we can merge this in? |
prostraction
added a commit
to uorg-saver/easyjson
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes the
X uintptr json:",omitempty"
omitempty applied to a zero-value uintptr is treated as empty by the stdlib json.Marshal, but wasn't by easyjson.