chore: Remove unwrap() from non-test code#298
Merged
marcoow merged 2 commits intomainmatter:mainfrom Mar 22, 2026
Merged
Conversation
TheJanzap
force-pushed
the
remove-unwrap
branch
from
15a9a4e to
c10f86e
Compare
marcoow
previously approved these changes
Mar 22, 2026
TheJanzap
force-pushed
the
remove-unwrap
branch
from
c10f86e to
0a2a521
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since using
unwrap()is bad practice, I replaced allunwraps()in non-test code withexpect()or similar. This fixesclippy::unwrap_usedwhen this lint is enabled.