Closed
Conversation
- Added Maize Searchable support in the app. - Configured searchable attributes for SourceCollection model. - Updated composer autoload and providers to register the package. - Added default match weight configuration. - Changed timezone to Asia/Jakarta. This improves search functionality by allowing customizable and weighted search attributes.
Member
|
Your changes look good, but could you please also update the GitHub Actions workflow to include tests for Laravel 12 and PHP 8.4? You'll need to add 12.x to the laravel matrix and 8.4 to the php matrix in the .github/workflows/run-tests.yml file. |
- Updated PHP version to 8.4 in phpstan and tests workflow. - Added Laravel 12 and Testbench 10 to the test matrix. This ensures compatibility with the latest PHP and Laravel versions.
Member
|
Just a couple more things:
Let me know if you have any questions. |
added 4 commits
June 23, 2025 18:05
- Refactored `AttributeUtilTest` to create `PostgresGrammar` with the DB connection for better clarity. - Updated PHPStan configuration by removing `checkMissingIterableValueType`. - Bumped development dependencies: - Updated Larastan to `^3.5.0`. - Updated Pest and related plugins to `^3.x`. - Updated Pint to `^1.22.1`. - Updated PHPStan-related packages to `^2.x`. - Extended Testbench compatibility to support version 10. These changes enhance test readability, ensure compatibility with the latest tooling, and cleanup outdated configurations.
- Updated the `composer.json` file to require PHP ^8.2. - Aligns package dependencies with the current PHP version support.
- Updated `composer.json` to support only Laravel 11 and 12. - Removed support for older versions of Laravel and Testbench.
- Removed Laravel 10 and Testbench 8 from the matrix. - Dropped PHP 8.1 support in tests. - Simplified configurations by limiting compatibility to maintained versions. Improves clarity and aligns testing with supported versions.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.