“â# Fix: Windows CRLF line ending compatibility for filters#1655
Closed
achuanya wants to merge 0 commit intomaizzle:masterfrom
Closed
“â# Fix: Windows CRLF line ending compatibility for filters#1655achuanya wants to merge 0 commit intomaizzle:masterfrom
achuanya wants to merge 0 commit intomaizzle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Windows CRLF line ending compatibility for filters
Root Cause
The regex /\n/g only matched Unix-style line breaks, leaving \r characters which corrupted the output.
Solution
Updated regex to /\r?\n/g to support both LF and CRLF."
Problem
The
filters.test.jstest was failing on Windows with this error:The diff showed corrupted output for
newline-to-brandstrip-newlinesfilters:Root Cause
In
src/transformers/filters/defaultFilters.js, two filter functions only matched Unix-style line endings (\n):Windows uses
\r\n(CRLF) for line breaks. The regex/\n/gonly replaced the\npart, leaving the\r(carriage return) character in the output.The
\rcharacter moves the cursor back to the beginning of the line, causing the output to appear truncated/overwritten when displayed or compared.Solution
Changed the regex from
/\n/gto/\r?\n/gto handle both Windows (CRLF) and Unix (LF) line endings:Files Changed
src/transformers/filters/defaultFilters.jsTesting
All 119 tests pass after this fix.