Open
Conversation
mak-42
requested changes
Nov 4, 2023
src/main/java/croc/education/ws2023spb/knightsmove/MyChessPosition.java
Outdated
Show resolved
Hide resolved
src/main/java/croc/education/ws2023spb/knightsmove/ChessPositionParser.java
Outdated
Show resolved
Hide resolved
src/main/java/croc/education/ws2023spb/knightsmove/IllegalMoveException.java
Outdated
Show resolved
Hide resolved
src/main/java/croc/education/ws2023spb/knightsmove/MyKnightsMoveChecker.java
Outdated
Show resolved
Hide resolved
mak-42
reviewed
Nov 12, 2023
src/main/java/croc/education/ws2023spb/knightsmove/IllegalMoveException.java
Outdated
Show resolved
Hide resolved
mak-42
reviewed
Nov 12, 2023
src/main/java/croc/education/ws2023spb/knightsmove/ChessPositionParser.java
Show resolved
Hide resolved
Owner
|
Спасибо за хорошую работу. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Создан класс MyChessPosition, описывающий позицию на шахматной доске: переопределен метод toString(), выводящий координаты позиции в формате шахматной нотации; конструктор, проверяющий корректность аргументов.
Реализован метод parse(), преобразующий строковую шахматную нотацию в позицию на шахматной доске (MyChessPosition).
Создан класс MyKnightsMoveChecker, проверяющий правильность хода коня.