fix: add Snowflake dialect to SQL parser#2
Merged
Conversation
Fixes Snowflake-Labs#161 by specifying dialect='snowflake' when parsing SQL with sqlglot. This ensures Snowflake-specific syntax (COPY, JSON paths, VARIANT casts, etc.) is correctly identified rather than classified as 'Unknown'. Also enables pytest in CI and adds comprehensive test coverage for both basic and Snowflake-specific SQL. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Remove unused pytest import - Fix spelling: unparseable -> unparsable - Fix quote style for ruff formatter Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dialect="snowflake"to sqlglot parserTest Results
Statements that work both with and without dialect (baseline)
SELECT * FROM my_tableINSERT INTO my_table VALUES (1, 2)COPY INTO my_table FROM @my_stageSELECT data:name FROM my_tableStatements FIXED by adding
dialect="snowflake"SELECT data:user.address.city FROM tSELECT data:count::INTEGER FROM tSELECT f.value FROM t, LATERAL FLATTEN(input => data:items) fCOPY INTO t FROM @stage PATTERN='*.csv' FILE_FORMAT=(...)COPY INTO @stage FROM t FILE_FORMAT=(TYPE='PARQUET')SELECT data:items[0]:name FROM tSELECT * FROM t WHERE data:status::STRING = 'active'SELECT ARRAY_SIZE(data:items) FROM tPUT file:///tmp/data.csv @my_stageTest Plan
🤖 Generated with Claude Code