Conversation
Promoting Develop to Master
Promoting Develop to Master
feat: Add airgapped support to Plane-Enterprise configuration (#148)
WalkthroughBumps Plane Enterprise Helm chart and app versions from 1.4.0/1.14.0 to 1.4.1/1.14.1. Updates corresponding defaults and references in README, questions.yml, and values.yaml. No logic, templates, or control flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
charts/plane-enterprise/questions.yml (1)
541-547: Fix Let’s Encrypt ACME v2 directory URLIn charts/plane-enterprise/questions.yml at lines 541–547 and 1002–1005, replace the incorrect default URL with the canonical production endpoint:
- default: "https://acme-v02.services.api.letsencrypt.org/directory" + default: "https://acme-v02.api.letsencrypt.org/directory"
🧹 Nitpick comments (1)
charts/plane-enterprise/questions.yml (1)
798-801: Potential default mismatch: Postgres volume size 5Gi here vs 2Gi elsewhere.values.yaml (Lines 46–47) and README list 2Gi; questions.yml shows 5Gi. Pick one to avoid user confusion.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
charts/plane-enterprise/Chart.yaml(1 hunks)charts/plane-enterprise/README.md(3 hunks)charts/plane-enterprise/questions.yml(1 hunks)charts/plane-enterprise/values.yaml(1 hunks)
🔇 Additional comments (6)
charts/plane-enterprise/values.yaml (1)
1-1: Version bump to v1.14.1 looks correct and consistent.Matches Chart.yaml appVersion and docs in this PR.
charts/plane-enterprise/questions.yml (1)
23-23: LGTM on default planeVersion bump.Default aligns with values.yaml and README.
charts/plane-enterprise/Chart.yaml (1)
8-9: Chart version/appVersion bump looks good.No other metadata changes needed for this back-merge.
charts/plane-enterprise/README.md (3)
14-16: Docs updated to v1.14.1 — good.Keeps install instructions in sync.
68-69: Minimum values snippet updated — good.Consistent with values.yaml/questions.yml.
94-95: Customization table default updated — good.Stays aligned with chart defaults.
Summary by CodeRabbit
Chores
Documentation