#19 Updating json handling to fix mcp for self hosted instances#20
Merged
Prashant-Surya merged 1 commit intomakeplane:canaryfrom Apr 28, 2025
Merged
#19 Updating json handling to fix mcp for self hosted instances#20Prashant-Surya merged 1 commit intomakeplane:canaryfrom
Prashant-Surya merged 1 commit intomakeplane:canaryfrom
Conversation
Prashant-Surya
approved these changes
Apr 28, 2025
Prashant-Surya
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed issues with the
makePlaneRequestfunction to properly handle GET requests versus non-GET requests. The changes ensure that the Content-Type header is only included for non-GET requests, and that the request body is only included for non-GET requests when it's not null.Type of Change
Screenshots and Media (if applicable)
Before:
After:
Test Scenarios
Tested changes by:
npx @modelcontextprotocol/inspector --config "path/to/build/index.js" --server planeand verifying that tools work correctlyThe changes fix how HTTP requests are built when interacting with the Plane API, ensuring proper behavior with GET and non-GET requests.
References
#19