Skip to content

[WEB-2338] chore: handle untitled page breadcrumbs #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SatishGandham merged 2 commits into from
Aug 28, 2024
Merged

[WEB-2338] chore: handle untitled page breadcrumbs #5445

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e9f7f
chore: handle untitle page titles
aaryan610 Aug 28, 2024
baf5a06
chore: store page title in a const
aaryan610 Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { Breadcrumbs, Button, EmojiIconPicker, EmojiIconPickerTypes, TOAST_TYPE,
import { BreadcrumbLink, Logo } from "@/components/common";
// helpers
import { convertHexEmojiToDecimal } from "@/helpers/emoji.helper";
import { getPageName } from "@/helpers/page.helper";
// hooks
import { usePage, useProject } from "@/hooks/store";
import { usePlatformOS } from "@/hooks/use-platform-os";
Expand Down Expand Up @@ -146,9 +147,9 @@ export const PageDetailsHeader = observer(() => {
}
/>
</div>
<Tooltip tooltipContent={name ?? "Page"} position="bottom" isMobile={isMobile}>
<Tooltip tooltipContent={getPageName(name)} position="bottom" isMobile={isMobile}>
<div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate">
{name ?? "Page"}
{getPageName(name)}
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Usage of getPageName in Tooltip

The use of getPageName function both for the tooltipContent and directly within the Tooltip component ensures consistency in how page names are displayed. This is crucial for handling pages without a specified title.

However, consider storing the result of getPageName(name) in a variable before the return statement to avoid calling the function twice with the same argument, which could potentially improve performance if the function is computationally expensive.

Consider this optimization:

- <Tooltip tooltipContent={getPageName(name)} position="bottom" isMobile={isMobile}>
-   <div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate">
-     {getPageName(name)}
-   </div>
- </Tooltip>
+ const pageTitle = getPageName(name);
+ <Tooltip tooltipContent={pageTitle} position="bottom" isMobile={isMobile}>
+   <div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate">
+     {pageTitle}
+   </div>
+ </Tooltip>
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<Tooltip tooltipContent={getPageName(name)} position="bottom" isMobile={isMobile}>
<div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate">
{name ?? "Page"}
{getPageName(name)}
const pageTitle = getPageName(name);
<Tooltip tooltipContent={pageTitle} position="bottom" isMobile={isMobile}>
<div className="relative line-clamp-1 block max-w-[150px] overflow-hidden truncate">
{pageTitle}

</div>
</Tooltip>
</div>
Expand Down