[WEB-2208] fix: space error message alignment#5542
Conversation
…/empty-state-alignment-projects-views-pages
WalkthroughThe changes involve an update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- space/core/components/issues/issue-layouts/error.tsx (1 hunks)
Additional comments not posted (1)
space/core/components/issues/issue-layouts/error.tsx (1)
6-6: Approved: Class change enhances error message alignment.The change from
h-fulltomin-h-screenon the outermost<div>is well-aligned with the PR's objectives to improve the vertical alignment of error messages. This ensures that the error message occupies at least the full height of the viewport, enhancing the user experience across different screen sizes.
|
|
||
| export const SomethingWentWrongError = () => ( | ||
| <div className="grid h-full w-full place-items-center p-6"> | ||
| <div className="grid min-h-screen w-full place-items-center p-6"> |
There was a problem hiding this comment.
Suggestion: Consider adding ARIA roles for better accessibility.
While the primary focus of this PR is on layout, it's also a good opportunity to enhance the accessibility of the error message. Consider adding appropriate ARIA roles and properties to improve screen reader support. For example, the outer <div> could have role="alert" to ensure that the error message is immediately announced to users of assistive technologies.
Changes:
The error message was taking the height of its parent.
Changed it to occupy the whole screen.
Which makes the vertical alignment for the following published items consistent:
New State
Previous State
Reference: [WEB-2208]
Summary by CodeRabbit