Skip to content

[WEB-2208] fix: space error message alignment#5542

Merged
pushya22 merged 2 commits intopreviewfrom
fix/empty-state-alignment-projects-views-pages
Sep 6, 2024
Merged

[WEB-2208] fix: space error message alignment#5542
pushya22 merged 2 commits intopreviewfrom
fix/empty-state-alignment-projects-views-pages

Conversation

@sharma01ketan
Copy link
Contributor

@sharma01ketan sharma01ketan commented Sep 6, 2024

Changes:

The error message was taking the height of its parent.
Changed it to occupy the whole screen.
Which makes the vertical alignment for the following published items consistent:

  1. Project
  2. Views
  3. Pages

New State

Screenshot 2024-09-06 at 1 58 52 PM

Previous State

Screenshot 2024-09-06 at 1 59 05 PM

Reference: [WEB-2208]

Summary by CodeRabbit

  • New Features
    • Enhanced the layout of the error component to ensure it occupies at least the full height of the viewport, improving visibility and user experience across different screen sizes.

@sharma01ketan sharma01ketan added 🐛bug Something isn't working 🌐frontend labels Sep 6, 2024
@sharma01ketan sharma01ketan added this to the v0.23-dev milestone Sep 6, 2024
@sharma01ketan sharma01ketan self-assigned this Sep 6, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 6, 2024

Walkthrough

The changes involve an update to the SomethingWentWrongError component in the error.tsx file. The outermost <div> element's class name was changed from h-full to min-h-screen, modifying its height behavior to ensure it occupies at least the full height of the viewport. This adjustment maintains the internal structure of the component while enhancing its visual presentation.

Changes

Files Change Summary
space/core/components/issues/issue-layouts/error.tsx Changed class name from h-full to min-h-screen on the outer <div> for height adjustment.

Poem

In a world where errors dwell,
A change was made, oh what a spell!
From h-full to min-h-screen,
Now the view is bright and keen.
Hop along, let joy take flight,
For every screen shines oh so bright! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 73654a2 and 646fb01.

Files selected for processing (1)
  • space/core/components/issues/issue-layouts/error.tsx (1 hunks)
Additional comments not posted (1)
space/core/components/issues/issue-layouts/error.tsx (1)

6-6: Approved: Class change enhances error message alignment.

The change from h-full to min-h-screen on the outermost <div> is well-aligned with the PR's objectives to improve the vertical alignment of error messages. This ensures that the error message occupies at least the full height of the viewport, enhancing the user experience across different screen sizes.


export const SomethingWentWrongError = () => (
<div className="grid h-full w-full place-items-center p-6">
<div className="grid min-h-screen w-full place-items-center p-6">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Consider adding ARIA roles for better accessibility.

While the primary focus of this PR is on layout, it's also a good opportunity to enhance the accessibility of the error message. Consider adding appropriate ARIA roles and properties to improve screen reader support. For example, the outer <div> could have role="alert" to ensure that the error message is immediately announced to users of assistive technologies.

@pushya22 pushya22 changed the title WEB-2208] fix: space error message alignment [WEB-2208] fix: space error message alignment Sep 6, 2024
@pushya22 pushya22 merged commit 9415a5b into preview Sep 6, 2024
@sriramveeraghanta sriramveeraghanta deleted the fix/empty-state-alignment-projects-views-pages branch February 10, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working 🌐frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants