[WEB-2735] chore: filter the deleted assignee from the issue

[NarayanBavisetti]

chore:

• this pull request filters the assignee removed from an issue.

Summary by CodeRabbit

• New Features
  • Enhanced filtering logic to exclude deleted assignees and cycles from results, improving data accuracy and relevance.

[coderabbitai]

Walkthrough

The changes introduce additional filtering logic in the filter_assignees and filter_cycle functions within the issue_filters.py file. Specifically, new lines are added to ensure that only non-deleted assignees and cycles are included in the results by checking that the deleted_at field is null. This modification refines the data returned when filtering issues, enhancing the accuracy of the queries.

Changes

File Path	Change Summary
apiserver/plane/utils/issue_filters.py	Added checks for deleted_at field in filter_assignees and filter_cycle to exclude deleted records.

Possibly related PRs

• [WEB-2626] chore: removed the deleted issue's count #5837: This PR modifies the get_queryset method to filter out issues marked as deleted by checking the deleted_at field, which is directly related to the changes made in the main PR that also involve filtering based on the deleted_at field for assignees and cycles.
• [WEB-2680] chore: updated queryset for soft delete #5844: This PR updates the queryset to handle soft-deleted records, which aligns with the main PR's focus on excluding deleted assignees and cycles from the results based on the deleted_at field.

Suggested labels

🌟improvement

Suggested reviewers

• sriramveeraghanta

Poem

🐇 In the fields where issues lay,
We filter out the ones gone gray.
With deleted_at now in sight,
Only the bright remain in light!
Hooray for clean data, what a delight! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7082f70 and d1a871f.

📒 Files selected for processing (1)

• apiserver/plane/utils/issue_filters.py (1 hunks)

🔇 Additional comments (1)

apiserver/plane/utils/issue_filters.py (1)

236-236: LGTM! Verify the impact on existing queries.

The addition of issue_assignee__deleted_at__isnull = True correctly filters out deleted assignees. This aligns with the PR objective and follows Django's best practices for soft deletion.

Let's verify that this change doesn't affect any existing queries that might rely on including deleted assignees:

✅ Verification successful

Based on the search results, I can now generate a final response as we have comprehensive evidence about how deleted_at is handled across the codebase:

The filter for deleted assignees is consistent with existing patterns

The addition of issue_assignee__deleted_at__isnull = True is verified to be correct and consistent with:

• Similar filters in other views (dashboard, intake, space views)
• Database models that enforce soft deletion constraints
• Other issue relationship filters (modules, cycles, labels)

The codebase consistently filters out soft-deleted relationships across all views and queries, making this change align with the established patterns.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any custom queries that might bypass the issue filters
# or explicitly handle deleted assignees

# Look for direct queryset operations on issue_assignee
rg -l "issue_assignee" | xargs rg "deleted_at"

# Look for any tests that might need updating
fd "test.*\.py" | xargs rg "issue_assignee.*deleted"

Length of output: 41780

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.