chore: Remove shouldIgnoreDependencies flags while dragging in timeline view #6150
Conversation
WalkthroughThe changes made in this pull request focus on the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (3)web/core/components/gantt-chart/helpers/blockResizables/use-gantt-resizable.ts (3)
The import of
The changes correctly implement the error handling with proper toast notification, addressing the critical bug from the previous review.
The removal of the ✅ Verification successfulRemoval of dragDirection parameter is correct and safe The verification shows that the change is consistent with the codebase:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for other usages of updateBlockPosition to ensure consistency
ast-grep --pattern 'updateBlockPosition($$$)'
# Search for any remaining shouldIgnoreDependencies flags
rg -i 'shouldIgnoreDependencies'
Length of output: 252 Script: #!/bin/bash
# Let's try to find the definition and usage of updateBlockPosition
ast-grep --pattern 'function updateBlockPosition($$$)'
# Also search for the function declaration in different formats
ast-grep --pattern 'const updateBlockPosition = ($$$)'
# Let's also search for any text containing updateBlockPosition
rg "updateBlockPosition" -A 3 -B 3
Length of output: 3157 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
web/core/components/gantt-chart/helpers/blockResizables/use-gantt-resizable.ts(2 hunks)
🔇 Additional comments (1)
web/core/components/gantt-chart/helpers/blockResizables/use-gantt-resizable.ts (1)
106-106: Verify dependency handling during block dragging
The removal of the dependency-ignoring parameter means dependencies will always be considered during dragging operations. This could affect the behavior of connected tasks in the Gantt chart.
Let's verify if this change is consistently applied:
✅ Verification successful
Let me search for more context about the updateBlockPosition function to understand its implementation and usage better.
Let me check the implementation of getUpdatedPositionAfterDrag since it was also mentioned in the original changes.
Based on the gathered evidence, I can now provide the final response:
Changes to dependency handling are consistently applied
The removal of the ignoreDependencies parameter is consistently implemented across the codebase:
- In
base-timeline.store.ts,updateBlockPositionmethod signature shows the parameter was removed - In
base-timeline.store.ts,getUpdatedPositionAfterDragimplementation also shows the parameter was removed - The only usage of
updateBlockPositioninuse-gantt-resizable.tshas been updated accordingly
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other occurrences of updateBlockPosition to ensure consistent behavior
ast-grep --pattern 'updateBlockPosition($$$)'
Length of output: 219
Script:
#!/bin/bash
# Search for the definition and usage of updateBlockPosition
ast-grep --pattern 'const updateBlockPosition = $_'
# Also search for any string containing updateBlockPosition to catch other patterns
rg "updateBlockPosition" -A 3
Length of output: 1927
Script:
#!/bin/bash
# Search for getUpdatedPositionAfterDrag implementation and usage
ast-grep --pattern 'getUpdatedPositionAfterDrag($$$)'
# Also search for any string containing getUpdatedPositionAfterDrag
rg "getUpdatedPositionAfterDrag" -A 5
Length of output: 2822
web/core/components/gantt-chart/helpers/blockResizables/use-gantt-resizable.ts
Outdated
Show resolved
Hide resolved
…ne view (makeplane#6150) * remove shouldEnable dependency flags for timeline view * chore: error handling --------- Co-authored-by: Prateek Shourya <[email protected]>
This PR removes the
shouldIgnoreDependenciesflag while dragging in timeline viewSummary by CodeRabbit
New Features
Bug Fixes