[WEB-2808] chore: remove workspace-level toggle from parent select modal #6227
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
web/core/components/issues/parent-issues-list-modal.tsx (1)
Line range hint
31-43: Consider adding documentation about workspace-level search removalSince this component previously supported workspace-level search, it would be helpful to add a comment in the Props type or component documentation explaining that parent issue search is now exclusively project-scoped. This will help future maintainers understand the intentional limitation.
type Props = { isOpen: boolean; handleClose: () => void; value?: any; onChange: (issue: ISearchIssueResponse) => void; + // Note: As of WEB-2808, parent issue search is intentionally limited to project scope projectId: string | undefined; issueId?: string; searchEpic?: boolean; };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/core/components/issues/parent-issues-list-modal.tsx(2 hunks)
🔇 Additional comments (2)
web/core/components/issues/parent-issues-list-modal.tsx (2)
12-12: LGTM: Import change is appropriate
The Loader import from @plane/ui is correctly used in the component's loading state implementation.
82-82: LGTM: Effect dependencies are correctly maintained
The dependency array has been properly updated to reflect the removal of the workspace-level toggle state while maintaining all necessary dependencies for the effect hook.
| parent: true, | ||
| issue_id: issueId, | ||
| workspace_search: isWorkspaceLevel, | ||
| workspace_search: false, |
There was a problem hiding this comment.
💡 Codebase verification
Hardcoding workspace_search: false requires additional changes
The verification reveals that other components still maintain workspace-level search functionality:
command-modal.tsxhas an active workspace toggle and usesworkspace_search: !projectId ? true : isWorkspaceLevelexisting-issues-list-modal.tsxhas a workspace toggle UI and usesworkspace_search: isWorkspaceLevel
While hardcoding workspace_search: false in parent-issues-list-modal.tsx aligns with other modals like select-duplicate.tsx and bulk-delete-issues-modal.tsx, it creates inconsistency with components that still support workspace-level search. This change should be part of a broader refactoring effort to remove workspace search functionality across all components.
🔗 Analysis chain
Verify impact of removing workspace-level search
The hardcoding of workspace_search: false aligns with the PR objective to remove workspace-level toggle. This ensures parent issue search is always project-scoped.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other components that might be affected by workspace_search parameter
rg -l "workspace_search" --type ts --type tsx
# Check for any remaining workspace-level toggle UI elements
ast-grep --pattern 'workspace_search = true'
Length of output: 120
Script:
#!/bin/bash
# Search for workspace_search usage with proper file extension patterns
rg -l "workspace_search" --type typescript --type-add 'typescript:*.{ts,tsx}'
# Check for any workspace search related UI or logic
rg -A 3 "workspace.*search" --type typescript --type-add 'typescript:*.{ts,tsx}'
Length of output: 5548
pushya22
deleted the
chore-remove-workspace-toggle-from-issue-parent-modal
branch
Description
This PR makes the following updates:
Type of Change
Media
Test Scenarios
Affected areas:
References
[WEB-2808]
Summary by CodeRabbit
New Features
ParentIssuesListModalcomponent by removing workspace-level search functionality.Bug Fixes