Skip to content

[PE-98] fix: page title fixed height #6242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Dec 20, 2024
Merged

[PE-98] fix: page title fixed height #6242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions web/core/components/pages/editor/editor-body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,14 +166,12 @@ export const PageEditorBody: React.FC<Props> = observer((props) => {
})}
>
<div className="size-full flex flex-col gap-y-7 overflow-y-auto overflow-x-hidden">
<div className="relative w-full flex-shrink-0 md:pl-5 px-4 h-[38px]">
<PageEditorTitle
editorRef={editorRef}
title={pageTitle}
updateTitle={updateTitle}
readOnly={!isContentEditable}
/>
</div>
<PageEditorTitle
editorRef={editorRef}
title={pageTitle}
updateTitle={updateTitle}
readOnly={!isContentEditable}
/>
<CollaborativeDocumentEditorWithRef
editable={isContentEditable}
id={pageId}
Expand Down
6 changes: 3 additions & 3 deletions web/core/components/pages/editor/title.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ export const PageEditorTitle: React.FC<Props> = observer((props) => {
});

return (
<>
<div className="relative w-full flex-shrink-0 md:pl-5 px-4">
{readOnly ? (
<h6 className={cn(titleClassName, "break-words")}>{title}</h6>
<h6 className={cn(titleClassName, "break-words pb-1.5")}>{title}</h6>
) : (
<>
<TextArea
Expand Down Expand Up @@ -71,6 +71,6 @@ export const PageEditorTitle: React.FC<Props> = observer((props) => {
</div>
</>
)}
</>
</div>
);
});
Loading