[WEB-2879]fix: label creation

[vamsikrishnamathala]

Description

This update changes the label addition option from a <p> tag to a <Combobox.Option> component within the IssueLabelSelect component. This modification ensures that the option behaves correctly within the Combobox.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Testing

• Verified that the label addition option is selectable and behaves as expected.
• Ensured that the label dropdown interaction was smooth and consistent at all occurrences.

References

WEB-2879

Summary by CodeRabbit

• New Features

  • Enhanced the functionality for adding new labels within the label selection component.
  • Introduced a new interactive option that prompts users to add a label based on input.

• Bug Fixes

  • Improved handling of label addition to ensure it only occurs with valid input.

[coderabbitai]

Walkthrough

The pull request modifies the IssueLabelSelect component in the label selection interface. The primary change involves replacing a <p> element with a <Combobox.Option> for adding new labels. This refactoring improves the integration of label creation within the Headless UI Combobox component, enhancing the interaction logic for adding labels. The modification ensures that label addition only occurs when there is valid input, maintaining the existing visual and functional behavior of the component.

Changes

File	Change Summary
web/core/components/issues/issue-detail/label/select/label-select.tsx	Replaced <p> element with <Combobox.Option> for new label addition, added input validation and event handling for label creation

Suggested labels

🎨UI / UX

Suggested reviewers

• SatishGandham
• rahulramesha
• gurusainath

Possibly related PRs

• [WEB-2678]feat: added functionality to add labels directly from dropdown #6211: Enhances label dropdown functionality with direct label addition
• [WEB-2678]fix: create labels empty state #6216: Improves handling of empty states during label creation

Poem

🐰 A Label's Tale of Coding Delight 🏷️

In Combobox's realm, a change takes flight,
With options dancing, options so bright
No empty labels shall slip through today
Our code now sings a more structured way!
Hop, hop, hooray for cleaner design! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea78c2b and 95736d6.

📒 Files selected for processing (1)

• web/core/components/issues/issue-detail/label/select/label-select.tsx (2 hunks)

🔇 Additional comments (1)

web/core/components/issues/issue-detail/label/select/label-select.tsx (1)

Line range hint 186-203: Consider refining the click handling logic within <Combobox.Option>.

1. The current approach of using both <Combobox.Option> selection and onClick with e.preventDefault()/e.stopPropagation() might cause some confusion about whether the label creation is fully handled by Combobox’s selection mechanics or by the custom click handler.
2. Double-check that keyboard-based selection triggers label creation as well, since relying on onClick alone might prevent non-pointer interactions from adding labels.
3. Consider adding error handling or user feedback if handleAddLabel fails (e.g., network errors). This improves the user experience and helps diagnose issues quickly.

If needed, I can provide a refactored example that integrates the click handler into the native <Combobox.Option> onSelect mechanism while preserving the condition that requires a non-empty query.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.