Skip to content

[WEB-2896] fix: mutation problem with issue properties while accepting an intake issue. #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Dec 26, 2024
Merged

[WEB-2896] fix: mutation problem with issue properties while accepting an intake issue. #6277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions web/core/local-db/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,10 @@ export const updatePersistentLayer = async (issueIds: string | string[]) => {
issueIds.forEach(async (issueId) => {
const dbIssue = await persistence.getIssue(issueId);
const issue = rootStore.issue.issues.getIssueById(issueId);
const updatedIssue = dbIssue ? { ...dbIssue, ...issue } : issue;

if (issue) {
addIssueToPersistanceLayer(issue);
if (updatedIssue) {
addIssueToPersistanceLayer(updatedIssue);
}
});
};
Expand Down
4 changes: 3 additions & 1 deletion web/core/store/inbox/inbox-issue.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ export class InboxIssueStore implements IInboxIssueStore {

// If issue accepted sync issue to local db
if (status === EInboxIssueStatus.ACCEPTED) {
addIssueToPersistanceLayer({ ...this.issue, ...inboxIssue.issue });
const updatedIssue = { ...this.issue, ...inboxIssue.issue };
this.store.issue.issues.addIssue([updatedIssue]);
await addIssueToPersistanceLayer(updatedIssue);
}
} catch {
runInAction(() => set(this, "status", previousData.status));
Expand Down
Loading