[WEB-3033] fix: active cycle graph tooltip and endpoint validation

[anmolsinghbhatia]

Description

This PR includes active cycle graph tooltip and endpoint validation.

Type of Change

• Bug fix
• Code refactoring

References

[WEB-3033]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in cycle details retrieval by using safer optional chaining techniques
  • Enhanced code robustness when accessing cycle-related data

[coderabbitai]

Walkthrough

The pull request introduces modifications to the useCyclesDetails function in the use-cycles-details.ts file. The changes focus on improving code safety by utilizing optional chaining (cycle?.id) when accessing cycle properties. This update prevents potential runtime errors that could occur when the cycle object is null or undefined, ensuring more robust conditional checks for fetching active cycle progress, duration, and estimate duration.

Changes

File	Change Summary
web/core/components/cycles/active-cycle/use-cycles-details.ts	Updated useCyclesDetails function to use optional chaining for safer property access on cycle object

Suggested reviewers

• sriramveeraghanta
• SatishGandham

Possibly related PRs

• [WEB-2903] fix: active cycle update payload #6270: Changes to handleFormSubmit method in CycleCreateUpdateModal related to cycle data handling

Poem

🐰 Hop, hop, through the code we go,
Optional chaining makes errors slow
Cycles dance with safer grace
No more null fears in this place!
CodeRabbit's magic, clear and bright ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

web/core/components/cycles/active-cycle/use-cycles-details.ts (2)

38-41: Refactor repeated conditional checks

You have repeated the workspaceSlug && projectId && cycle?.id && !cycle?.distribution condition. Consider extracting it into a well-named boolean variable (e.g., canFetchDistribution) for improved readability and maintainability.

---

46-49: Consolidate repeated SWR fetch logic

The pattern workspaceSlug && projectId && cycle?.id && !cycle?.estimate_distribution is used similarly to the distribution check. Grouping common conditions or extracting them into constants or local variables can make the code more concise and less error-prone.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a13a64 and b490267.

📒 Files selected for processing (1)

• web/core/components/cycles/active-cycle/use-cycles-details.ts (1 hunks)

🔇 Additional comments (1)

web/core/components/cycles/active-cycle/use-cycles-details.ts (1)

33-34: Good use of optional chaining for robustness

Checking cycle?.id instead of cycle helps prevent null or undefined access errors. This is a solid improvement in code safety.