[WEB-3074] regression: logic to generate page link for redirection/copying

[aaryan610]

Description

This PR replaces the local and unscalable logic to construct a page link with the getRedirectionLink computedFn from the page instance.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• Refactor
  • Updated page operations hook to simplify page link generation
  • Removed URL parameter extraction from hook
  • Adjusted hook dependencies and method signatures

[coderabbitai]

Walkthrough

The pull request modifies the usePageOperations hook in the web/core/hooks/use-page-operations.ts file. The changes primarily involve removing the dependency on useParams from next/navigation and introducing a new getRedirectionLink method in the page object. This refactoring simplifies the link generation logic by relying on the getRedirectionLink method instead of manually constructing URLs from URL parameters. The hook's return type is also explicitly defined to improve type clarity.

Changes

File	Change Summary
web/core/hooks/use-page-operations.ts	- Removed useParams hook usage - Added getRedirectionLink method for page link generation - Updated useMemo dependencies - Explicitly defined return type for usePageOperations

Suggested reviewers

• SatishGandham
• pushya22

Possibly related PRs

• [PE-93] regression: mentions in space app, entity search #6250: Removal of useParams hook and workspaceSlug parameter, similar to the modifications in this PR

Poem

🐰 A Rabbit's Ode to Refactoring 🔗

Links now dance with grace so light,
getRedirectionLink shines so bright
Params vanish, code becomes clean
A hook transformed, a coder's dream!
Simplicity hops, logic takes flight 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2622dd6 and 7af9a59.

📒 Files selected for processing (1)

• web/core/hooks/use-page-operations.ts (2 hunks)

🔇 Additional comments (3)

web/core/hooks/use-page-operations.ts (3)

37-46: Ensure type-safety on destructured functions.

While destructuring the page object, confirm that the properties (access, duplicate, getRedirectionLink, etc.) are correctly typed within TPageInstance. If these properties are optional in load-time or can be null/undefined, consider adding safeguards or fallback logic.

---

51-51: Validate the path format for pageLink.

getRedirectionLink() might already generate a fully qualified or absolute path. Currently, openInNewTab prepends an additional slash. If pageLink starts with /, the resulting URL might contain unintended double slashes. Verify that the link is formatted correctly to avoid broken or redundant paths.

---

193-193: Good job integrating getRedirectionLink into useMemo dependencies.

Including getRedirectionLink in the dependency array is crucial for properly recalculating operations whenever the link changes.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.