Skip to content

[WEB-2943] chore: app theme store #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Jan 10, 2025
Merged

[WEB-2943] chore: app theme store #6356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions web/core/store/theme.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ export interface IThemeStore {
workspaceAnalyticsSidebarCollapsed: boolean | undefined;
issueDetailSidebarCollapsed: boolean | undefined;
epicDetailSidebarCollapsed: boolean | undefined;
initiativesSidebarCollapsed: boolean | undefined;
projectOverviewSidebarCollapsed: boolean | undefined;
// actions
toggleSidebar: (collapsed?: boolean) => void;
toggleProfileSidebar: (collapsed?: boolean) => void;
toggleWorkspaceAnalyticsSidebar: (collapsed?: boolean) => void;
toggleIssueDetailSidebar: (collapsed?: boolean) => void;
toggleEpicDetailSidebar: (collapsed?: boolean) => void;
toggleInitiativesSidebar: (collapsed?: boolean) => void;
toggleProjectOverviewSidebar: (collapsed?: boolean) => void;
}

export class ThemeStore implements IThemeStore {
Expand All @@ -22,6 +26,8 @@ export class ThemeStore implements IThemeStore {
workspaceAnalyticsSidebarCollapsed: boolean | undefined = undefined;
issueDetailSidebarCollapsed: boolean | undefined = undefined;
epicDetailSidebarCollapsed: boolean | undefined = undefined;
initiativesSidebarCollapsed: boolean | undefined = undefined;
projectOverviewSidebarCollapsed: boolean | undefined = undefined;
Comment on lines +29 to +30
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Initialize sidebar states from localStorage.

The new sidebar states should be initialized from localStorage in the constructor, similar to other sidebar states.

Add initialization in the constructor:

   constructor() {
+    // Initialize from localStorage
+    this.initiativesSidebarCollapsed = localStorage.getItem("initiatives_sidebar_collapsed") === "true";
+    this.projectOverviewSidebarCollapsed = localStorage.getItem("project_overview_sidebar_collapsed") === "true";

     makeObservable(this, {

Committable suggestion skipped: line range outside the PR's diff.


constructor() {
makeObservable(this, {
Expand All @@ -31,12 +37,16 @@ export class ThemeStore implements IThemeStore {
workspaceAnalyticsSidebarCollapsed: observable.ref,
issueDetailSidebarCollapsed: observable.ref,
epicDetailSidebarCollapsed: observable.ref,
initiativesSidebarCollapsed: observable.ref,
projectOverviewSidebarCollapsed: observable.ref,
// action
toggleSidebar: action,
toggleProfileSidebar: action,
toggleWorkspaceAnalyticsSidebar: action,
toggleIssueDetailSidebar: action,
toggleEpicDetailSidebar: action,
toggleInitiativesSidebar: action,
toggleProjectOverviewSidebar: action,
});
}

Expand Down Expand Up @@ -96,4 +106,22 @@ export class ThemeStore implements IThemeStore {
}
localStorage.setItem("epic_detail_sidebar_collapsed", this.epicDetailSidebarCollapsed.toString());
};

toggleInitiativesSidebar = (collapsed?: boolean) => {
if (collapsed === undefined) {
this.initiativesSidebarCollapsed = !this.initiativesSidebarCollapsed;
} else {
this.initiativesSidebarCollapsed = collapsed;
}
localStorage.setItem("initiatives_sidebar_collapsed", this.initiativesSidebarCollapsed.toString());
};

toggleProjectOverviewSidebar = (collapsed?: boolean) => {
if (collapsed === undefined) {
this.projectOverviewSidebarCollapsed = !this.projectOverviewSidebarCollapsed;
} else {
this.projectOverviewSidebarCollapsed = collapsed;
}
localStorage.setItem("project_overview_sidebar_collapsed", this.projectOverviewSidebarCollapsed.toString());
};
}
Loading