Skip to content

Conversation

@sangeethailango
Copy link
Member

@sangeethailango sangeethailango commented Jan 10, 2025

Description

This PR will fix where bots list as project members in the user recents.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected field names in workspace serializer for clarity and accuracy.
    • Enhanced project member retrieval to exclude bot members and include only active members.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the workspace.py serializers in the API server. The changes include refining the project member retrieval logic by excluding bot members and correcting serializer field names. The get_project_members method in the ProjectRecentVisitSerializer now filters out bot members, while the WorkspaceHomePreferenceSerializer has its read_only_fields corrected to use the proper field names.

Changes

File Change Summary
apiserver/plane/app/serializers/workspace.py - Modified get_project_members to exclude bot members with member__is_bot=False
- Corrected read_only_fields in WorkspaceHomePreferenceSerializer:
worspaceworkspace
update_byupdated_by

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta
  • rahulramesha

Poem

🐰 Bots begone, members shine bright,
Serializers dancing with delight!
Typos fixed, names now clear,
Code's precision brings us cheer!
A rabbit's refactor, clean and light! 🔧


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6a881e and 983e1f6.

📒 Files selected for processing (1)
  • apiserver/plane/app/serializers/workspace.py (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sangeethailango sangeethailango changed the title [WEB 3099] fix: listing bots as project members [WEB 3099] fix: listing bots as project members in recents Jan 10, 2025
@pushya22 pushya22 merged commit 8db51ab into preview Jan 10, 2025
10 of 13 checks passed
@pushya22 pushya22 deleted the fix-recents-project-members branch January 10, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️backend 🐛bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants