Skip to content

[WEB-3078] chore: empty state config #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 4 commits into from
Jan 15, 2025
Merged

[WEB-3078] chore: empty state config #6397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1079dd3
chore: empty state config updated
anmolsinghbhatia Jan 15, 2025
7507f8f
chore: code refactor
anmolsinghbhatia Jan 15, 2025
a895f18
chore: date range picker icon updated
anmolsinghbhatia Jan 15, 2025
b849e68
fix: tree map content css
prateekshourya29 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/core/components/core/charts/tree-map/map-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export const CustomTreeMapContent: React.FC<any> = ({
L${pX},${pY + LAYOUT.RADIUS}
Q${pX},${pY} ${pX + LAYOUT.RADIUS},${pY}
`}
className={cn("transition-colors duration-200 hover:opacity-90 cursor-pointer", fillClassName)}
className={cn("transition-colors duration-200 hover:opacity-90", fillClassName)}
fill={fillColor ?? "currentColor"}
/>

Expand Down Expand Up @@ -269,7 +269,7 @@ export const CustomTreeMapContent: React.FC<any> = ({

return (
<g>
<rect x={x} y={y} width={width} height={height} fill="transparent" className="cursor-pointer" />
<rect x={x} y={y} width={width} height={height} fill="transparent" />
{renderContent()}
</g>
);
Expand Down
14 changes: 7 additions & 7 deletions web/core/components/dropdowns/date-range.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import React, { useEffect, useRef, useState } from "react";
import { Placement } from "@popperjs/core";
import { DateRange, DayPicker, Matcher } from "react-day-picker";
import { usePopper } from "react-popper";
import { ArrowRight, CalendarDays } from "lucide-react";
import { ArrowRight, CalendarCheck2, CalendarDays } from "lucide-react";
import { Combobox } from "@headlessui/react";
// ui
import { Button, ComboDropDown } from "@plane/ui";
Expand Down Expand Up @@ -33,7 +33,6 @@ type Props = {
from?: boolean;
to?: boolean;
};
icon?: React.ReactNode;
minDate?: Date;
maxDate?: Date;
onSelect: (range: DateRange | undefined) => void;
Expand All @@ -50,6 +49,7 @@ type Props = {
to: Date | undefined;
};
renderByDefault?: boolean;
renderPlaceholder?: boolean;
};

export const DateRangeDropdown: React.FC<Props> = (props) => {
Expand All @@ -68,7 +68,6 @@ export const DateRangeDropdown: React.FC<Props> = (props) => {
from: true,
to: true,
},
icon = <CalendarDays className="h-3 w-3 flex-shrink-0" />,
minDate,
maxDate,
onSelect,
Expand All @@ -82,6 +81,7 @@ export const DateRangeDropdown: React.FC<Props> = (props) => {
tabIndex,
value,
renderByDefault = true,
renderPlaceholder = true,
} = props;
// states
const [isOpen, setIsOpen] = useState(false);
Expand Down Expand Up @@ -166,15 +166,15 @@ export const DateRangeDropdown: React.FC<Props> = (props) => {
<span
className={cn("h-full flex items-center justify-center gap-1 rounded-sm flex-grow", buttonFromDateClassName)}
>
{!hideIcon.from && icon}
{dateRange.from ? renderFormattedDate(dateRange.from) : placeholder.from}
{!hideIcon.from && <CalendarDays className="h-3 w-3 flex-shrink-0" />}
{dateRange.from ? renderFormattedDate(dateRange.from) : renderPlaceholder ? placeholder.from : ""}
</span>
<ArrowRight className="h-3 w-3 flex-shrink-0" />
<span
className={cn("h-full flex items-center justify-center gap-1 rounded-sm flex-grow", buttonToDateClassName)}
>
{!hideIcon.to && icon}
{dateRange.to ? renderFormattedDate(dateRange.to) : placeholder.to}
{!hideIcon.to && <CalendarCheck2 className="h-3 w-3 flex-shrink-0" />}
{dateRange.to ? renderFormattedDate(dateRange.to) : renderPlaceholder ? placeholder.to : ""}
</span>
</DropdownButton>
</button>
Expand Down
17 changes: 16 additions & 1 deletion web/core/constants/empty-state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ export enum EmptyStateType {
ISSUE_RELATION_EMPTY_STATE = "issue-relation-empty-state",
ISSUE_COMMENT_EMPTY_STATE = "issue-comment-empty-state",

EPIC_RELATION_SEARCH_EMPTY_STATE = "epic-relation-search-empty-state",
EPIC_RELATION_EMPTY_STATE = "epic-relation-empty-state",

NOTIFICATION_DETAIL_EMPTY_STATE = "notification-detail-empty-state",
NOTIFICATION_ALL_EMPTY_STATE = "notification-all-empty-state",
NOTIFICATION_MENTIONS_EMPTY_STATE = "notification-mentions-empty-state",
Expand Down Expand Up @@ -639,14 +642,26 @@ const emptyStateDetails = {
},
[EmptyStateType.ISSUE_RELATION_SEARCH_EMPTY_STATE]: {
key: EmptyStateType.ISSUE_RELATION_SEARCH_EMPTY_STATE,
title: "No maching issues found",
title: "No matching issues found",
path: "/empty-state/search/search",
},
[EmptyStateType.ISSUE_RELATION_EMPTY_STATE]: {
key: EmptyStateType.ISSUE_RELATION_EMPTY_STATE,
title: "No issues found",
path: "/empty-state/search/issues",
},

[EmptyStateType.EPIC_RELATION_SEARCH_EMPTY_STATE]: {
key: EmptyStateType.EPIC_RELATION_SEARCH_EMPTY_STATE,
title: "No matching epics found",
path: "/empty-state/search/search",
},
[EmptyStateType.EPIC_RELATION_EMPTY_STATE]: {
key: EmptyStateType.EPIC_RELATION_EMPTY_STATE,
title: "No epics found",
path: "/empty-state/search/issues",
},

[EmptyStateType.ISSUE_COMMENT_EMPTY_STATE]: {
key: EmptyStateType.ISSUE_COMMENT_EMPTY_STATE,
title: "No comments yet",
Expand Down
Loading