-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[PE-238] refactor: page store hooks #6409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1eb4c82
refactor: page store hooks
aaryan610 d56baf3
fix: page details instances
aaryan610 52b3625
fix: build errors
aaryan610 eedcb56
Merge branch 'preview' of https://github.com/makeplane/plane into ref…
aaryan610 8d7054a
refactor: page store hooks
aaryan610 6da322e
fix: minor bug
aaryan610 d8bbfd2
fix: merge conflicts resolved from preview
aaryan610 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export * from "./use-page-store"; | ||
| export * from "./use-page"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { useContext } from "react"; | ||
| // context | ||
| import { StoreContext } from "@/lib/store-context"; | ||
| // mobx store | ||
| import { IProjectPageStore } from "@/store/pages/project-page.store"; | ||
|
|
||
| export enum EPageStoreType { | ||
| PROJECT = "PROJECT_PAGE", | ||
| } | ||
|
|
||
| export type TReturnType = { | ||
| [EPageStoreType.PROJECT]: IProjectPageStore; | ||
| }; | ||
|
|
||
| export const usePageStore = <T extends EPageStoreType>(storeType: T): TReturnType[T] => { | ||
| const context = useContext(StoreContext); | ||
| if (context === undefined) throw new Error("usePageStore must be used within StoreProvider"); | ||
|
|
||
| if (storeType === EPageStoreType.PROJECT) { | ||
| return context.projectPages; | ||
| } | ||
|
|
||
| throw new Error(`Invalid store type: ${storeType}`); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { useContext } from "react"; | ||
| // mobx store | ||
| import { StoreContext } from "@/lib/store-context"; | ||
| // plane web hooks | ||
| import { EPageStoreType, usePageStore } from "@/plane-web/hooks/store"; | ||
|
|
||
| export type TArgs = { | ||
| pageId: string; | ||
| storeType: EPageStoreType; | ||
| }; | ||
|
|
||
| export const usePage = (args: TArgs) => { | ||
| const { pageId, storeType } = args; | ||
| // context | ||
| const context = useContext(StoreContext); | ||
| // store hooks | ||
| const pageStore = usePageStore(storeType); | ||
|
|
||
| if (context === undefined) throw new Error("usePage must be used within StoreProvider"); | ||
| if (!pageId) throw new Error("pageId is required"); | ||
|
|
||
| return pageStore.getPageById(pageId); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.