[WEB-3172]fix: issue create in layouts.

[vamsikrishnamathala]

Description

This update fixes store type fallback logic in issue modal.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-3172

Summary by CodeRabbit

• Refactor
  • Simplified the logic for determining the storeType variable in the issue modal component using nullish coalescing operator.

[makeplane]

Pull Request Linked with Plane Issues

Comment Automatically Generated by Plane

[makeplane]

Pull Request Linked with Plane Issues

Comment Automatically Generated by Plane

[makeplane]

Pull Request Linked with Plane Issues

Comment Automatically Generated by Plane

[coderabbitai]

Walkthrough

The pull request modifies the CreateUpdateIssueModalBase component in the web/core/components/issues/issue-modal/base.tsx file. The primary change involves simplifying the assignment logic for the storeType variable by using the nullish coalescing operator (??). This refactoring reduces the complexity of the conditional assignment, making the code more concise while maintaining the same functional behavior for determining the issue store type.

Changes

File	Change Summary
web/core/components/issues/issue-modal/base.tsx	Simplified storeType assignment using nullish coalescing operator, replacing previous conditional logic

Suggested labels

🐛bug

Suggested reviewers

• SatishGandham
• rahulramesha

Possibly related PRs

• [WEB-2878]fix: draft creation #6230: Changes to CreateUpdateIssueModalBase component's issue creation and update logic
• [WEB-2807] fix: Root issue store to have updated url params at all times #6147: URL parameters modifications in IssueRootStore
• [WEB-2817] fix: creating a new sub-issue from workspace level #6169: Modifications to IssueDetailWidgetModals component

Poem

🐰 A rabbit's code refrain, oh so neat
Nullish coalescing, a syntactic treat
Simplifying logic with a magical ??
Making assignments clearer than they were
Code poetry in motion, lean and bright! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ae1ce0 and 7b37756.

📒 Files selected for processing (1)

• web/core/components/issues/issue-modal/base.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

web/core/components/issues/issue-modal/base.tsx (1)

45-45: Simplified store type fallback logic looks good, but verify EPIC case handling.

The change simplifies the store type assignment using the nullish coalescing operator, making the code more maintainable. However, the special handling of EIssuesStoreType.EPIC case has been removed.

Let's verify that removing the EPIC case handling doesn't introduce any regressions:

✅ Verification successful

Removal of EPIC case handling is correct and safe.

The codebase shows that EPIC store type handling is properly managed at the form level and through layout-specific components. The simplified fallback logic in the modal base is more maintainable and aligns with the application's architecture.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for EPIC-related store type handling in the codebase

# Search for EPIC store type usage
echo "Checking EPIC store type usage..."
rg "EIssuesStoreType\.EPIC" -A 5 -B 5

# Search for epic-related issue creation
echo "Checking epic issue creation patterns..."
ast-grep --pattern 'createIssue($$$epic$$$)'

Length of output: 19372

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.