Skip to content

[WEB-3194]fix: stickies modal close while redirection #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 2 commits into from
Jan 22, 2025
Merged

[WEB-3194]fix: stickies modal close while redirection #6440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5270a
fix: stickies modal close while redirection
vamsikrishnamathala Jan 21, 2025
aa39ff2
chore: added deafult for optional prop
vamsikrishnamathala Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion web/core/components/stickies/layout/stickies-truncated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@ import { useSticky } from "@/hooks/use-stickies";
import { ContentOverflowWrapper } from "../../core/content-overflow-HOC";
import { StickiesLayout } from "./stickies-list";

export const StickiesTruncated = observer(() => {
type StickiesTruncatedProps = {
handleClose?: () => void;
};

export const StickiesTruncated = observer((props: StickiesTruncatedProps) => {
const { handleClose = () => {} } = props;
// navigation
const { workspaceSlug } = useParams();
// store hooks
Expand All @@ -33,6 +38,7 @@ export const StickiesTruncated = observer(() => {
className={cn(
"gap-1 w-full text-custom-primary-100 text-sm font-medium transition-opacity duration-300 bg-custom-background-90/20"
)}
onClick={handleClose}
Copy link
Collaborator

@gakshita gakshita Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleClose is optional here so can you render it conditionally?

>
Show all
</Link>
Expand Down
2 changes: 1 addition & 1 deletion web/core/components/stickies/modal/stickies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export const Stickies = observer((props: TProps) => {
</div>
{/* content */}
<div className="mb-4 max-h-[625px] overflow-scroll">
<StickiesTruncated />
<StickiesTruncated handleClose={handleClose} />
</div>
</div>
);
Expand Down
Loading