feat: home language support without stickies #6443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request introduces comprehensive internationalization (i18n) support across multiple components in the Plane application. The changes primarily focus on adding translation capabilities to various frontend components, updating translation files for multiple languages (English, Spanish, French, Japanese, and Chinese), and modifying type definitions to support localization. The modifications enable dynamic text rendering based on the user's language preferences, enhancing the application's global accessibility. Changes
Sequence DiagramsequenceDiagram
participant User
participant UI
participant TranslationService
participant LocaleFiles
User->>UI: Change Language
UI->>TranslationService: Request Translations
TranslationService->>LocaleFiles: Fetch Translation Keys
LocaleFiles-->>TranslationService: Return Translated Strings
TranslationService-->>UI: Provide Localized Text
UI->>User: Display Localized Interface
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (13)
web/core/components/home/widgets/empty-states/links.tsx (1)
2-2: LGTM! Consider adding type safety for translations.The i18n implementation is clean and follows best practices. Consider using typed translation keys to prevent runtime errors from typos or missing translations.
// Add type safety for translation keys import { TFunction } from "@plane/i18n";Also applies to: 4-14
web/core/components/home/widgets/empty-states/stickies.tsx (1)
2-2: Maintain consistent translation key hierarchy.The translation key
stickies.emptydoesn't follow the same hierarchical pattern as other home components (e.g.,home.quick_links.empty). Consider updating for consistency:- <div className="text-custom-text-400 text-sm text-center my-auto">{t("stickies.empty")}</div> + <div className="text-custom-text-400 text-sm text-center my-auto">{t("home.stickies.empty")}</div>Also applies to: 6-6, 11-11
web/core/components/home/widgets/manage/index.tsx (1)
Line range hint
3-3: Consider modern React patterns.The
FCtype is generally discouraged in modern React as it doesn't provide significant benefits and can mask type issues. Consider:-export const ManageWidgetsModal: FC<TProps> = observer((props) => { +export const ManageWidgetsModal = observer((props: TProps) => {Also applies to: 16-16
web/core/components/home/widgets/empty-states/recents.tsx (1)
2-2: Consider adding error handling for invalid type values.While the translation implementation is correct, the switch case doesn't handle invalid type values explicitly. Consider adding error handling or type validation.
const getDisplayContent = () => { + if (!["project", "page", "issue"].includes(type)) { + console.warn(`Invalid type "${type}" provided to RecentsEmptyState`); + return { + icon: <History size={30} className="text-custom-text-400/40" />, + text: t("home.recents.empty.default"), + }; + } switch (type) { case "project": return {Also applies to: 6-6, 12-12, 17-17, 22-22, 27-27
web/app/[workspaceSlug]/(projects)/header.tsx (1)
10-10: Consider accessibility improvement for GitHub star link.While the translation implementation is correct, the hidden text might affect screen readers. Consider using
sr-onlyclass instead ofhiddenfor better accessibility.- <span className="hidden text-xs font-medium sm:hidden md:block">{t("home.star_us_on_github")}</span> + <span className="sr-only">{t("home.star_us_on_github")}</span> + <span className="hidden text-xs font-medium sm:hidden md:block">{t("home.star_us_on_github")}</span>Also applies to: 23-23, 33-35, 58-58
web/core/components/home/user-greetings.tsx (1)
Line range hint
43-45: Extract time-based logic into a separate function.The greeting and emoji selection logic could be extracted into a utility function for better maintainability and reusability.
Consider creating a utility function:
const getTimeBasedGreeting = (hour: number) => { const greeting = hour < 12 ? "morning" : hour < 18 ? "afternoon" : "evening"; const emoji = greeting === "morning" ? "🌤️" : greeting === "afternoon" ? "🌥️" : "🌙️"; return { greeting, emoji }; };Also applies to: 53-57
web/core/components/home/widgets/links/root.tsx (2)
39-42: Remove unnecessary whitespace in JSX.The explicit whitespace character and empty lines make the code less maintainable.
Apply this diff:
- <div className="text-base font-semibold text-custom-text-350"> - {" "} - {t("home.quick_links.title", { count: 2 })} - </div> + <div className="text-base font-semibold text-custom-text-350"> + {t("home.quick_links.title", { count: 2 })} + </div>
43-50: Enhance button accessibility.The button lacks proper ARIA attributes for better accessibility.
Apply this diff:
<button onClick={() => { toggleLinkModal(true); }} + aria-label={t("home.quick_links.add")} className="flex gap-1 text-sm font-medium text-custom-primary-100 my-auto" > <Plus className="size-4 my-auto" /> <span>{t("home.quick_links.add")}</span>web/core/components/home/widgets/manage/widget-list.tsx (2)
Line range hint
17-46: Improve error handling in handleDrop function.The current error handling doesn't provide specific error information to users. Consider capturing and translating specific error cases.
Apply this diff:
try { reorderWidget(workspaceSlug, sourceData.id, droppedId, instruction); setToast({ type: TOAST_TYPE.SUCCESS, title: t("toast.success"), message: t("home.widget.reordered_successfully"), }); - } catch { + } catch (error) { setToast({ type: TOAST_TYPE.ERROR, title: t("toast.error"), - message: t("home.widget.reordering_failed"), + message: t("home.widget.reordering_failed_with_reason", { + reason: error instanceof Error ? error.message : t("common.unknown_error") + }), }); }
Line range hint
17-31: Consider extracting drop target validation logic.The drop target validation logic in handleDrop is complex and could be extracted for better maintainability.
Consider creating a separate function:
const validateDropTarget = ( dropTargets: DropTargetRecord[], ): DropTargetRecord | null => { if (!dropTargets?.length) return null; return dropTargets.length > 1 ? dropTargets.find((target) => target?.data?.isChild) : dropTargets[0]; };web/core/components/home/widgets/links/link-detail.tsx (1)
44-45: Consider aligning translation key structure with other files.The translation keys here are flat (e.g., "edit", "link_copied") while other files use a hierarchical structure. Consider using a consistent pattern:
-t("edit") +t("quick_links.actions.edit") -t("link_copied") +t("quick_links.toasts.link_copied.title")Also applies to: 54-54, 60-60, 66-66, 72-72
web/core/components/home/widgets/recents/index.tsx (1)
8-8: LGTM! Consider enhancing type safety for i18n keys.The i18n implementation for filters looks good. Consider creating a type for the i18n keys to prevent typos and enable better IDE support.
type THomeRecentI18nKeys = | "home.recents.filters.all" | "home.recents.filters.issues" | "home.recents.filters.pages" | "home.recents.filters.projects"; const filters: { name: TRecentActivityFilterKeys; icon?: React.ReactNode; i18n_key: THomeRecentI18nKeys }[] = [ // ... rest of the array ];Also applies to: 25-29
web/core/components/home/widgets/empty-states/root.tsx (1)
31-32: LGTM! Consider extracting translation keys to constants.The translation keys are consistently structured but could benefit from being centralized in a constants file to avoid duplication and enable easier maintenance.
// constants/i18n-keys.ts export const HOME_EMPTY_KEYS = { CREATE_PROJECT: { TITLE: "home.empty.create_project.title", DESCRIPTION: "home.empty.create_project.description", CTA: "home.empty.create_project.cta" }, // ... other sections } as const;Also applies to: 35-35, 47-48, 51-51, 57-58, 61-61, 67-68, 88-88
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (27)
packages/i18n/src/locales/en/translations.json(1 hunks)packages/i18n/src/locales/es/translations.json(1 hunks)packages/i18n/src/locales/fr/translations.json(1 hunks)packages/i18n/src/locales/ja/translations.json(1 hunks)packages/i18n/src/locales/zh-CN/translations.json(1 hunks)packages/types/src/home.d.ts(1 hunks)web/app/[workspaceSlug]/(projects)/header.tsx(4 hunks)web/app/[workspaceSlug]/(projects)/page.tsx(2 hunks)web/core/components/core/content-overflow-HOC.tsx(3 hunks)web/core/components/home/home-dashboard-widgets.tsx(1 hunks)web/core/components/home/index.ts(0 hunks)web/core/components/home/project-empty-state.tsx(0 hunks)web/core/components/home/user-greetings.tsx(4 hunks)web/core/components/home/widgets/empty-states/links.tsx(1 hunks)web/core/components/home/widgets/empty-states/recents.tsx(1 hunks)web/core/components/home/widgets/empty-states/root.tsx(6 hunks)web/core/components/home/widgets/empty-states/stickies.tsx(1 hunks)web/core/components/home/widgets/links/action.tsx(2 hunks)web/core/components/home/widgets/links/create-update-link-modal.tsx(6 hunks)web/core/components/home/widgets/links/link-detail.tsx(4 hunks)web/core/components/home/widgets/links/root.tsx(3 hunks)web/core/components/home/widgets/links/use-links.tsx(3 hunks)web/core/components/home/widgets/manage/index.tsx(2 hunks)web/core/components/home/widgets/manage/widget-item.tsx(3 hunks)web/core/components/home/widgets/manage/widget-list.tsx(2 hunks)web/core/components/home/widgets/recents/filters.tsx(3 hunks)web/core/components/home/widgets/recents/index.tsx(5 hunks)
💤 Files with no reviewable changes (2)
- web/core/components/home/index.ts
- web/core/components/home/project-empty-state.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (14)
web/core/components/home/widgets/links/action.tsx (1)
2-2: LGTM! Clean i18n implementation.The translation implementation follows best practices and maintains consistent key hierarchy.
Also applies to: 9-9, 19-19
web/core/components/home/widgets/manage/index.tsx (1)
7-7: LGTM! Clean i18n implementation.The translation implementation follows best practices and maintains consistent key hierarchy.
Also applies to: 20-20, 25-25
web/app/[workspaceSlug]/(projects)/page.tsx (1)
5-5: LGTM! Clean i18n implementation.The translation implementation is correct and consistent with other components.
Also applies to: 15-15, 17-17
packages/types/src/home.d.ts (1)
4-4: Verify all usages of TRecentActivityFilterKeys.The change from "all item" to "all" is a breaking change. Let's verify all components using this type have been updated.
✅ Verification successful
No issues found with TRecentActivityFilterKeys usage
The codebase is already using the correct values ("all", "issue", "page", "project") in all implementations. No updates needed.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining usages of "all item" that might need updating rg -l "all item" --type ts --type tsx # Search for components using TRecentActivityFilterKeys ast-grep --pattern 'TRecentActivityFilterKeys'Length of output: 377
Script:
#!/bin/bash # Check implementation in both files echo "=== index.tsx ===" rg "TRecentActivityFilterKeys" -A 5 -B 5 web/core/components/home/widgets/recents/index.tsx echo -e "\n=== filters.tsx ===" rg "TRecentActivityFilterKeys" -A 5 -B 5 web/core/components/home/widgets/recents/filters.tsxLength of output: 2509
web/core/components/home/widgets/recents/filters.tsx (1)
15-15: Consider backward compatibility for type changes.Adding the required
i18n_keyfield to thefilterstype might break existing code. Consider making it optional withi18n_key?: stringor providing a migration guide.Run this script to check for potential breaking changes:
web/core/components/home/home-dashboard-widgets.tsx (1)
28-28: LGTM! Consistent i18n key structure.The translation keys follow a clear hierarchical pattern (
home.<widget_name>.title), making the structure maintainable and easy to understand.Also applies to: 33-33, 38-38, 43-43, 48-48
web/core/components/home/widgets/links/use-links.tsx (2)
57-59: LGTM! Consistent toast message structure.The translation keys follow a clear pattern (
quick_links.toasts.<action>.<type>), making maintenance and updates straightforward.Also applies to: 64-66, 76-78, 82-84
37-39: Verify error message fallback behavior.While the i18n implementation looks good, the error message fallback combines server error with translation key:
error?.data?.error ?? "quick_links.toasts.not_created.message"This might lead to inconsistent error display if the server returns an error message in a different language.
Consider standardizing error handling to always use translated messages:
-error?.data?.error ?? "quick_links.toasts.not_created.message" +t("quick_links.toasts.not_created.message")Also applies to: 45-47
web/core/components/core/content-overflow-HOC.tsx (1)
3-3: LGTM! Appropriate use of simple translation keys.Since this is a generic, reusable component, using simple translation keys ("show_less", "show_all") is appropriate. The implementation is clean and straightforward.
Also applies to: 35-37, 149-149
web/core/components/home/widgets/recents/index.tsx (2)
39-39: LGTM! Clean implementation of title translations.The translation hook is properly initialized and the title translation is implemented correctly.
Also applies to: 75-75
92-92: LGTM! Consistent translation key usage.Good practice: Using the same translation key consistently for the title across both empty and non-empty states.
web/core/components/home/widgets/links/create-update-link-modal.tsx (1)
72-72: Verify translation completeness for form validation messages.While the implementation looks good overall, ensure that all possible form validation messages are included in the translation files. Also, consider using a more specific translation key for generic actions like "Cancel", "Update", "Adding", etc.
Also applies to: 77-78, 84-84, 94-94, 99-99, 103-104, 117-117, 127-127, 130-131
✅ Verification successful
All translation keys are properly defined, but consider namespacing generic actions
All form validation messages and UI texts are properly included in the translation files. However, for better maintainability, consider using more specific translation keys for generic actions (e.g.,
link.modal.actions.updateinstead ofUpdate).🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if all form-related translation keys exist in the English locale rg -t json '"link\.modal\.' packages/i18n/src/locales/en/Length of output: 59
Script:
#!/bin/bash # Find all translation keys used in the file ast-grep --pattern 't($STR)' web/core/components/home/widgets/links/create-update-link-modal.tsx # Search for translation files and their content echo "=== Translation files ===" fd . packages/i18n/src/locales/en -e json -x cat {} # Search for common action translations echo "=== Common actions ===" rg -t json '"(Update|Add|Cancel)"' packages/i18n/src/locales/en/Length of output: 22826
web/core/components/home/widgets/manage/widget-item.tsx (1)
133-133: Verify pluralization handling in translations.The code passes a count parameter to the translation function, but it's hardcoded to 1. This might limit proper pluralization support if needed in the future.
packages/i18n/src/locales/ja/translations.json (1)
369-369: Verify pluralization format for Japanese.The pluralization format might not be appropriate for Japanese language:
"title": "クイック{count, plural, one{#リンク} other{#リンク}}"Please confirm if this pluralization format is necessary for Japanese, as the language typically doesn't distinguish between singular and plural forms in the same way as English.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/core/components/workspace/sidebar/user-menu.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
sriramveeraghanta
changed the base branch from
preview
to
feat-language-support
anmolsinghbhatia
approved these changes
Jan 27, 2025
prateekshourya29
approved these changes
Jan 27, 2025
prateekshourya29
merged commit 571c3f6
into
feat-language-support
7 of 11 checks passed
1 task
sriramveeraghanta
added a commit
that referenced
this pull request
Feb 6, 2025
* chore: ln support modules constants * fix: translation key * chore: empty state refactor (#6404) * chore: asset path helper hook added * chore: detailed and simple empty state component added * chore: section empty state component added * chore: language translation for all empty states * chore: new empty state implementation * improvement: add more translations * improvement: user permissions and workspace draft empty state * chore: update translation structure * chore: inbox empty states * chore: disabled project features empty state * chore: active cycle progress empty state * chore: notification empty state * chore: connections translation * chore: issue comment, relation, bulk delete, and command k empty state translation * chore: project pages empty state and translations * chore: project module and view related empty state * chore: remove project draft related empty state * chore: project cycle, views and archived issues empty state * chore: project cycles related empty state * chore: project settings empty state * chore: profile issue and acitivity empty state * chore: workspace settings realted constants * chore: stickies and home widgets empty state * chore: remove all reference to deprecated empty state component and constnats * chore: add support to ignore theme in resolved asset path hook * chore: minor updates * fix: build errors --------- Co-authored-by: Prateek Shourya <[email protected]> Co-authored-by: sriram veeraghanta <[email protected]> * fix: language support fo profile (#6461) * fix: ln support fo profile * fix: merge changes * fix: merge changes * [WEB-3165]feat: language support for issues (#6452) * * chore: moved issue constants to packages * chore: restructured issue constants * improvement: added translations to issue constants * chore: updated translation structure * * chore: updated chinese, spanish and french translation * chore: updated translation for issues mobile header * chore: updated spanish translation * chore: removed translation for issue priorities * fix: build errors * chore: minor updates --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: migrated filters.ts to packages (#6459) Co-authored-by: Prateek Shourya <[email protected]> * chore: workspace drafts constant moved to plane constant package * feat: home language support without stickies (#6443) * feat: home language support without stickies * fix: home sidebar * fix: added missing keys * fix: show all btn * fix: recents empty state * chore: translation update * feat: workspace constant language support and refactor (#6462) * chore: workspace constant language support and refactor * chore: workspace constant language support and refactor * chore: code refactor * chore: code refactor * merge conflict * chore: code refactor --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: tab indices constant moved to plane package (#6464) * chore: notification language support and refactor * chore: ln support for inbox constants (#6432) * chore: ln support for inbox constants * fix: snooze duration * fix: enum * fix: translation keys * fix: inbox status icon * fix: status icon * fix: naming --------- Co-authored-by: Prateek Shourya <[email protected]> * fix: ln support for views constants (#6431) * fix: ln support for views constants * fix: added translation * fix: translation keys * fix: access * chore: code refactor * chore: ln support workspace projects constants (#6429) * chore: ln support workspace projects constants * fix: translation key * fix: removed state translation * fix: removed state translation * fi: added translations * Chore: theme language support and refactor (#6465) * chore: themes language support and refactor * chore: theme language support and refactor * fix * [WEB-3173] chore: language support for cycles constant file (#6415) * chore: ln support for cycles constant file * fix: added chinese * fix: lint * fix: translation key * fix: build errors * minor updates * chore: minor translation update * chore: minor translation update * refactor: move labels contants to packages * refactor: move swr, file and error related constants to packages * chore: timezones constant moved to plane package * chore: metadata constant code refactor * chore: code refactor * fix: dashboard constants moved * chore: code refactor (#6478) * refactor: spreadsheet constants * chore: drafts language support (#6485) * chore: workspace drafts language support * chore: code refactor * feat: ln support for notifications (#6486) * feat: ln support for notifications * fix: translations * * refactor: moved page constants to packages (#6480) * fix: removed use-client * chore: removed unnecessary commnets * chore: workspace draft language support (#6490) * chore: workspace drafts language support * chore: code refactor * chore: draft language support * Feat constant event tracker (#6479) * fix: event tracjer constants * fix: constants event tracker * feat: language translation - projects list (#6493) * feat: added translation to projects list page * chore: restructured translation file * chore: module language support (#6499) * chore: module language support added * chore: code refactor * chore: workspace views language support (#6492) * chore: workspace views language support * chore: code refactor * feat: custom analytics language support (#6494) * feat: custom analytics language support * fix: key * fix: refactoring --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: minor improvements * feat: language support for intake (#6498) * feat: language support for intake * fix: key name * refactor: authentications related translations * feat: language support issues (#6501) * enhancement: added translations for issue list view * chore: added translations for issue detail widgets * chore: added missing translations * chore: modified issue to work items * chore: updated translations * Feat: workspace settings language support (#6508) * feat: language support for workspace settings * fix: lint * fix: export title * chore project settings language support (#6502) * chore: project settings language support * chore: code refactor * refactor: workspace creation related translations * chore: renamed issues to work items * fix: build errors * fix: lint * chore: modified translations * chore: remove duplicate * improvement: french translation * chore: chinese translation improvement * fix: japanese translations * chore: added spanish translation * minor improvements * fix: miscelleous language translations * fix: clear_all key * fix: moved user permission constants (#6516) * feat: language support for issues (#6513) * chore: added language support to issue detail widgets * improvement: added translation for issue detail * enhancement: added language trasnlation to issue layouts * chore: translation improvement (#6518) * feat: language support description (#6519) * enhancement: added language support for description * fix: updated keys * chore: renamed issue to work item (#6522) * chore: replace missing issue occurances to work items * fix: build errors * minor improvements * fix: profile links * Feat ln cycles (#6528) * feat: added language support for cycles * feat: added language support for cycles * chore: added core.json * fix: translation keys * fix: translation keys (#6530) * fix: changed sidebar keys * fix: removed extras * fix: updated keys * chore: optimize translation imports * fix: updated keys (#6534) * fix: updated keys * fix-sub work items toasts * chore: add missing translation and minor fixes * chore: code refactor * fix: language support keys (#6553) * minor improvements * minor fixes * fix: remove lucide import from constants package * chore: regenerate all translations * chore: addded chinese and japanese translation files * chore: remove all from translations * fix: added member * fix: language support keys (#6558) * fix: renamed keys * fix: space app * chore: renamed issues to work items * chore: update site manifest * chore: updated translations * fix: lang keys * chore: update translations --------- Co-authored-by: gakshita <[email protected]> Co-authored-by: Anmol Singh Bhatia <[email protected]> Co-authored-by: sriram veeraghanta <[email protected]> Co-authored-by: Akshita Goyal <[email protected]> Co-authored-by: Vamsi Krishna <[email protected]> Co-authored-by: Anmol Singh Bhatia <[email protected]> Co-authored-by: Vamsi krishna <[email protected]> Co-authored-by: Vamsi Krishna <[email protected]>
6 tasks
aaryan610
added a commit
that referenced
this pull request
Apr 9, 2025
* chore: ln support modules constants * fix: translation key * chore: empty state refactor (#6404) * chore: asset path helper hook added * chore: detailed and simple empty state component added * chore: section empty state component added * chore: language translation for all empty states * chore: new empty state implementation * improvement: add more translations * improvement: user permissions and workspace draft empty state * chore: update translation structure * chore: inbox empty states * chore: disabled project features empty state * chore: active cycle progress empty state * chore: notification empty state * chore: connections translation * chore: issue comment, relation, bulk delete, and command k empty state translation * chore: project pages empty state and translations * chore: project module and view related empty state * chore: remove project draft related empty state * chore: project cycle, views and archived issues empty state * chore: project cycles related empty state * chore: project settings empty state * chore: profile issue and acitivity empty state * chore: workspace settings realted constants * chore: stickies and home widgets empty state * chore: remove all reference to deprecated empty state component and constnats * chore: add support to ignore theme in resolved asset path hook * chore: minor updates * fix: build errors --------- Co-authored-by: Prateek Shourya <[email protected]> Co-authored-by: sriram veeraghanta <[email protected]> * feat: extended language translations support * fix: language support fo profile (#6461) * fix: ln support fo profile * fix: merge changes * fix: merge changes * [WEB-3137] refactor: empty states and add language support (#2235) * chore: asset path helper hook added * chore: detailed and simple empty state component added * chore: section empty state component added * chore: language translation for all empty states * chore: new empty state implementation * improvement: add more translations * improvement: user permissions and workspace draft empty state * chore: update translation structure * chore: inbox empty states * chore: disabled project features empty state * chore: active cycle progress empty state * chore: notification empty state * chore: connections translation * chore: issue comment, relation, bulk delete, and command k empty state translation * chore: project pages empty state and translations * chore: project module and view related empty state * chore: remove project draft related empty state * chore: project cycle, views and archived issues empty state * chore: project cycles related empty state * chore: project settings empty state * chore: profile issue and acitivity empty state * chore: workspace settings realted constants * chore: stickies and home widgets empty state * chore: remove all reference to deprecated empty state component and constnats * chore: team related empty states refactor and translation * chore: initiatives related empty states refactor and translation * chore: workspace pages related empty states refactor and translation * chore: epics related empty states refactor and translation * chore: workspace and project cycles related empty states refactor and translation * chore: command modal related empty states refactor and translation * chore: projects related empty states refactor and translation * chore: seperate out enterprise translations --------- Co-authored-by: Anmol Singh Bhatia <[email protected]> * [WEB-3165]feat: language support for issues (#6452) * * chore: moved issue constants to packages * chore: restructured issue constants * improvement: added translations to issue constants * chore: updated translation structure * * chore: updated chinese, spanish and french translation * chore: updated translation for issues mobile header * chore: updated spanish translation * chore: removed translation for issue priorities * fix: build errors * chore: minor updates --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: migrated filters.ts to packages (#6459) Co-authored-by: Prateek Shourya <[email protected]> * chore: workspace drafts constant moved to plane constant package * feat: home language support without stickies (#6443) * feat: home language support without stickies * fix: home sidebar * fix: added missing keys * fix: show all btn * fix: recents empty state * chore: translation update * feat: workspace constant language support and refactor (#6462) * chore: workspace constant language support and refactor * chore: workspace constant language support and refactor * chore: code refactor * chore: code refactor * merge conflict * chore: code refactor --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: tab indices constant moved to plane package (#6464) * chore: notification language support and refactor * [WEB-3165]feat:language support for issues. (#2282) * * chore: moved issue constants to packages * chore: restructured issue constants * improvement: added translations to issue constants * chore: updated translation structure * * chore: updated chinese, spanish and french translation * chore: updated translation for issues mobile header * * chore: updated imports for constants * improvemnt: added new translations * chore: updated spanish translation * chore: removed translation for issue priorities * chore: minor updates --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: filters migration to packages (#2298) * chore: migrated filter.ts to packages * core: updated filter.ts imports to packages * chore: added missing translation keys --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: ln support for inbox constants (#6432) * chore: ln support for inbox constants * fix: snooze duration * fix: enum * fix: translation keys * fix: inbox status icon * fix: status icon * fix: naming --------- Co-authored-by: Prateek Shourya <[email protected]> * fix: ln support for views constants (#6431) * fix: ln support for views constants * fix: added translation * fix: translation keys * fix: access * chore: code refactor * feat: workspace constant language support and code refactor (#2305) * chore: code refactor * fix: workspace settings order * chore: code refactor --------- Co-authored-by: Prateek Shourya <[email protected]> * chore: ln support workspace projects constants (#6429) * chore: ln support workspace projects constants * fix: translation key * fix: removed state translation * fix: removed state translation * fi: added translations * Chore: theme language support and refactor (#6465) * chore: themes language support and refactor * chore: theme language support and refactor * fix * [WEB-3173] chore: language support for cycles constant file (#6415) * chore: ln support for cycles constant file * fix: added chinese * fix: lint * fix: translation key * fix: build errors * fix: build errors * minor updates * chore: english extended translations * chore: minor translation update * chore: minor translation update * chore: minor translation update * refactor: move labels contants to packages * refactor: move swr, file and error related constants to packages * chore: timezones constant moved to plane package * chore: metadata constant code refactor * chore: code refactor * fix: dashboard constants moved * chore: code refactor (#6478) * refactor: spreadsheet constants * chore: drafts language support (#6485) * chore: workspace drafts language support * chore: code refactor * feat: ln support for notifications (#6486) * feat: ln support for notifications * fix: translations * * refactor: moved page constants to packages (#6480) * fix: removed use-client * chore: removed unnecessary commnets * chore: workspace draft language support (#6490) * chore: workspace drafts language support * chore: code refactor * chore: draft language support * Feat constant event tracker (#6479) * fix: event tracjer constants * fix: constants event tracker * feat: language translation - projects list (#6493) * feat: added translation to projects list page * chore: restructured translation file * chore: module language support (#6499) * chore: module language support added * chore: code refactor * chore: workspace views language support (#6492) * chore: workspace views language support * chore: code refactor * feat: custom analytics language support (#6494) * feat: custom analytics language support * fix: key * fix: refactoring --------- Co-authored-by: Prateek Shourya <[email protected]> * fix: build errors * chore: minor improvements * feat: language support for intake (#6498) * feat: language support for intake * fix: key name * refactor: authentications related translations * feat: language support issues (#6501) * enhancement: added translations for issue list view * chore: added translations for issue detail widgets * chore: added missing translations * chore: modified issue to work items * chore: updated translations * Feat: workspace settings language support (#6508) * feat: language support for workspace settings * fix: lint * fix: export title * chore project settings language support (#6502) * chore: project settings language support * chore: code refactor * refactor: workspace creation related translations * chore: renamed issues to work items * fix: build errors * fix: lint * chore: modified translations * chore: remove duplicate * improvement: french translation * chore: chinese translation improvement * fix: japanese translations * chore: added spanish translation * add missing translations * minor improvements * add missing translations and build fixes * fix: miscelleous language translations * refactor: move all issue types related types, constants and helpers to packages (#2345) * refactor: move all issue types related types, constants and helpers to packages * remove unused imports * fix: clear_all key * chore: initiatives language support (#2341) * chore: initiatives settings language support * chore: initiatives list page language support * chore: initiatives detail translation support * fix: moved user permission constants (#6516) * feat: language support for issues (#6513) * chore: added language support to issue detail widgets * improvement: added translation for issue detail * enhancement: added language trasnlation to issue layouts * chore: translation improvement (#6518) * feat: language support description (#6519) * enhancement: added language support for description * fix: updated keys * chore: initiatives toasts language support (#2347) * chore: initiatives settings language support * chore: initiatives list page language support * chore: initiatives detail translation support * chore: initiatives translation support * chore: code refactor * refactor: change issue type to work item type and add translations (#2351) * refactor: replace all occurances of issues and work items * refactor: replace all occurances of issues and work items (#2354) * chore: renamed issue to work item (#6522) * chore: replace missing issue occurances to work items * fix: build errors * chore: minor translations update * fix: build errors * minor improvements * fix: build errors * chore: update teamspace empty states * chore: work items * fix: profile links * Feat ln cycles (#6528) * feat: added language support for cycles * feat: added language support for cycles * chore: added core.json * fix: translation keys * fix: translation keys (#6530) * fix: changed sidebar keys * fix: removed extras * fix: updated keys * chore: optimize translation imports * fix: langugae support (#2358) * fix: added missing keys * fix: workspace settings * chore: translation import optimization (#2360) * chore: optimize translation imports * fix: extended core * fix: removed pro_trial * fix: key fix --------- Co-authored-by: gakshita <[email protected]> * fix: updated keys (#6534) * fix: updated keys * fix-sub work items toasts * fix: minor translations related bugs * fix: build errors * chore: add missing translation and minor fixes * chore: code refactor * chore: code refactor * fix: language support keys (#6553) * minor improvements * minor fixes * fix: remove lucide import from constants package * fix: remove lucide import from constants package * chore: regenerate all enterprise level translations * chore: remove all from translations * chore: regenerate all translations * chore: addded chinese and japanese translation files * chore: remove all from translations * chore: dashboard translation * fix: added member * fix: language support keys (#6558) * fix: renamed keys * fix: space app * chore: renamed issues to work items * chore: update site manifest * chore: updated translations * fix: lang keys * fix: fixed key names (#2413) Co-authored-by: Prateek Shourya <[email protected]> * chore: update translations --------- Co-authored-by: gakshita <[email protected]> Co-authored-by: Anmol Singh Bhatia <[email protected]> Co-authored-by: sriram veeraghanta <[email protected]> Co-authored-by: Akshita Goyal <[email protected]> Co-authored-by: Anmol Singh Bhatia <[email protected]> Co-authored-by: Vamsi Krishna <[email protected]> Co-authored-by: Vamsi krishna <[email protected]> Co-authored-by: Vamsi Krishna <[email protected]> Co-authored-by: Aaryan Khandelwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit
Release Notes
Internationalization
Home Dashboard
User Experience
Minor Improvements