-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[WEB-3198]fix: handled label overflow in modules #6451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request introduces layout modifications in two React components: Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/core/components/modules/analytics-sidebar/progress-stats.tsx (1)
138-145: Refine text truncation and inline element usage.
Thetruncateclass on the outer container may cause unintended trimming, especially if the container lacks a fixed width or overflow style. Additionally, using<p>(a block element) for label text that displays inline with the color indicator might be semantically inconsistent. Consider reverting to<span>or ensuring the wrapping element is configured appropriately for block-level rendering.For instance:
- <p className="text-xs text-ellipsis truncate">{label.title ?? "No labels"}</p> + <span className="text-xs text-ellipsis truncate">{label.title ?? "No labels"}</span>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
web/core/components/core/sidebar/single-progress-stats.tsx(1 hunks)web/core/components/modules/analytics-sidebar/progress-stats.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- web/core/components/core/sidebar/single-progress-stats.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
Description
This update handles the label overflow in the sidebar for Modules.
Type of Change
References
WEB-3198
Summary by CodeRabbit