[PE-265] fix: adding link to editor via floating toolbar #6517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/editor/src/core/components/menus/bubble-menu/link-selector.tsx (2)
23-35: Enhance URL validation and protocol handling.While the current implementation works, consider these improvements:
- Support for HTTPS protocol by default instead of HTTP
- Handle more URL formats (e.g., FTP, custom protocols)
- Provide more specific error messages based on validation failure reason
Consider this enhanced implementation:
const handleLinkSubmit = useCallback(() => { const input = inputRef.current; if (!input) return; let url = input.value; if (!url) return; - if (!url.startsWith("http")) url = `http://${url}`; + // Support common protocols or default to HTTPS + const commonProtocols = ['http:', 'https:', 'ftp:', 'mailto:']; + const hasProtocol = commonProtocols.some(protocol => url.startsWith(protocol)); + if (!hasProtocol) url = `https://${url}`; + if (isValidHttpUrl(url)) { setLinkEditor(editor, url); setIsOpen(false); setError(false); } else { setError(true); + // Set more specific error message based on validation failure + const errorMessage = url.includes('://') + ? 'Invalid URL format' + : 'Please enter a valid URL'; + setErrorMessage(errorMessage); } }, [editor, inputRef, setIsOpen]);
58-109: Enhance accessibility for the link selector.While the UI implementation looks good, consider these accessibility improvements:
- Add ARIA labels for error messages
- Include role attributes for interactive elements
- Add keyboard navigation between buttons
Apply these accessibility enhancements:
<div className={cn("flex rounded border border-custom-border-300 transition-colors", { "border-red-500": error, })} + role="group" + aria-label="Link editor" > <input ref={inputRef} type="url" placeholder="Enter or paste a link" onClick={(e) => e.stopPropagation()} className="flex-1 border-r border-custom-border-300 bg-custom-background-100 py-2 px-1.5 text-xs outline-none placeholder:text-custom-text-400 rounded" defaultValue={editor.getAttributes("link").href || ""} + aria-invalid={error} + aria-describedby={error ? "link-error-message" : undefined} onKeyDown={(e) => { setError(false); if (e.key === "Enter") { e.preventDefault(); handleLinkSubmit(); + } else if (e.key === "Tab") { + // Prevent focus trap + e.stopPropagation(); } }} onFocus={() => setError(false)} autoFocus /> {/* ... buttons ... */} </div> {error && ( <p className="text-xs text-red-500 my-1 px-2 pointer-events-none animate-in fade-in slide-in-from-top-0" + id="link-error-message" + role="alert" > Please enter a valid URL </p> )}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/editor/src/core/components/menus/bubble-menu/link-selector.tsx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (2)
packages/editor/src/core/components/menus/bubble-menu/link-selector.tsx (2)
2-2: LGTM! Icon import updated consistently.The Trash2 icon import aligns with its usage in the component.
19-19: LGTM! Error state added for validation feedback.The error state addition improves user feedback for invalid URLs.
Palanikannan1437
approved these changes
Jan 30, 2025
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes-
Type of Change
Summary by CodeRabbit
New Features
Bug Fixes