Skip to content

Conversation

@aaryan610
Copy link
Member

@aaryan610 aaryan610 commented Jan 30, 2025

Description

This PR fixes the table flicker effect on resizing in case any table cell has multiple cells or table has a header row.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Style
    • Updated paragraph styling in the editor to improve spacing and layout
    • Refined padding rules for paragraphs, especially within table contexts
    • Adjusted bottom padding for paragraph elements to enhance visual consistency

@aaryan610 aaryan610 added this to the v0.24.0 milestone Jan 30, 2025
@aaryan610 aaryan610 changed the title [PE-269] fix: table flixker on resize [PE-269] fix: table flicker on resize Jan 30, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

Walkthrough

The pull request introduces modifications to the CSS styling for paragraph elements within the ProseMirror editor. The changes focus on refining padding rules for paragraphs, particularly within table structures. The updated CSS selectively applies bottom padding to paragraph blocks, ensuring consistent spacing while preventing unwanted padding in table cells.

Changes

File Change Summary
packages/editor/src/styles/editor.css Updated paragraph styling rules to conditionally apply padding, specifically excluding paragraphs in table cells from bottom padding

Possibly related PRs

Suggested reviewers

  • Palanikannan1437
  • sriramveeraghanta

Poem

🐰 Padding pixels dance and play,
In tables where paragraphs sway,
No extra space where cells reside,
CSS rules now carefully glide,
A typographic rabbit's delight! 📏✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a37a2c and e6cf27c.

📒 Files selected for processing (1)
  • packages/editor/src/styles/editor.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
packages/editor/src/styles/editor.css (1)

411-418: LGTM! Clean fix for table flickering.

The changes effectively prevent table flickering by excluding bottom padding from paragraphs within table cells (td, th), while maintaining proper spacing for paragraphs elsewhere. This eliminates layout shifts during table resizing.

The implementation is clean and follows best practices:

  • Properly handles both table header (th) and data (td) cells
  • Maintains consistent spacing outside tables (4px for last child, 8px for others)
  • Uses efficient CSS selectors and nesting

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit ddad176 into preview Jan 30, 2025
10 of 14 checks passed
@aheckmann aheckmann deleted the fix/table-flicker branch April 29, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants