fix: command palette search

[prateekshourya29]

Description

This PR, fixed an issue where workspace level search toggle was not working. This happened due to recent changes in the command palette where we update the project id from router to workItemDetai.projectId. Due to this change now the projectId was alway undefined until we are inside a work item detail page, breaking other logics which are dependent on projectId. To fix this, I have added routerProjectId as a fallback case.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

• Bug Fixes

  • Prevented potential display issues by ensuring that command groups only render when all necessary data is present.

• New Features

  • Updated the command modal to better handle project information. The interface now automatically disables certain controls when project details aren’t available, improving overall usability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce additional conditional logic within two components. In the search results component, a guard clause prevents rendering when the necessary section is undefined. In the command modal, the useParams hook now retrieves a projectId (aliased as routerProjectId) and uses it as a fallback when issueDetails does not supply a project ID, with an associated disabled state on the toggle switch. These modifications adjust the control flow to handle missing values more robustly.

Changes

File	Change Summary
web/core/.../search-results.tsx	Added a conditional check (if (!currentSection) return null;) to prevent rendering when currentSection is undefined.
web/core/.../command-modal.tsx	Modified use of useParams to extract projectId (aliased as routerProjectId), set projectId via fallback logic, and added disabled={!projectId} on ToggleSwitch.

Sequence Diagram(s)

sequenceDiagram
    participant SR as SearchResults
    participant CG as CommandGroup Renderer
    SR ->> SR: Check if currentSection is defined
    alt currentSection exists
        SR ->> CG: Render command group
    else undefined
        SR -->> SR: Return null
    end

Loading

sequenceDiagram
    participant CM as CommandModal
    participant UP as useParams
    participant ID as IssueDetails
    participant TS as ToggleSwitch
    CM ->> UP: Retrieve workspaceSlug, routerProjectId, workItem
    CM ->> ID: Check for project_id
    alt issueDetails provides project_id
        CM ->> CM: Set projectId = issueDetails.project_id
    else
        CM ->> CM: Set projectId = routerProjectId
    end
    CM ->> TS: Set disabled = !projectId

Loading

Possibly related PRs

• [WEB-3410] fix: work item permission and validation #6621: Adjustments related to project ID parameter handling align with the modifications introduced in this PR.

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

• sriramveeraghanta
• anmolsinghbhatia

Poem

I'm a coding bunny on a quest,
Hopping through logic with extra zest,
Guarding each section with a careful check,
And toggling switches to keep things in check.
Errors hidden, my code is bright—
A bouncy journey into the night!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bcc295 and fec2c0d.

📒 Files selected for processing (2)

• web/core/components/command-palette/actions/search-results.tsx (1 hunks)
• web/core/components/command-palette/command-modal.tsx (3 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.